fix(http): fixed support for IPv6 literal strings in url (#5731)

Rishi556 · web-flow · commit 364993f0d8bc · 2024-09-01T00:47:25.000+03:00
diff --git a/lib/adapters/http.js b/lib/adapters/http.js
@@ -427,7 +427,7 @@ export default isHttpAdapterSupported && function httpAdapter(config) {
     if (config.socketPath) {
       options.socketPath = config.socketPath;
     } else {
-      options.hostname = parsed.hostname;
+      options.hostname = parsed.hostname.startsWith("[") ? parsed.hostname.slice(1, -1) : parsed.hostname;
       options.port = parsed.port;
       setProxy(options, config.proxy, protocol + '//' + parsed.hostname + (parsed.port ? ':' + parsed.port : '') + options.path);
     }
diff --git a/test/unit/adapters/http.js b/test/unit/adapters/http.js
@@ -159,6 +159,44 @@ describe('supports http with nodejs', function () {
     delete process.env.no_proxy;
   });
 
+  it('should support IPv4 literal strings', function (done) {
+
+    var data = {
+      firstName: 'Fred',
+      lastName: 'Flintstone',
+      emailAddr: 'fred@example.com'
+    };
+
+    server = http.createServer(function (req, res) {
+      res.setHeader('Content-Type', 'application/json');
+      res.end(JSON.stringify(data));
+    }).listen(4444, function () {
+      axios.get('http://127.0.0.1:4444/').then(function (res) {
+        assert.deepEqual(res.data, data);
+        done();
+      }).catch(done);
+    });
+  });
+
+  it('should support IPv6 literal strings', function (done) {
+
+    var data = {
+      firstName: 'Fred',
+      lastName: 'Flintstone',
+      emailAddr: 'fred@example.com'
+    };
+
+    server = http.createServer(function (req, res) {
+      res.setHeader('Content-Type', 'application/json');
+      res.end(JSON.stringify(data));
+    }).listen(4444, function () {
+      axios.get('http://[::1]:4444/').then(function (res) {
+        assert.deepEqual(res.data, data);
+        done();
+      }).catch(done);
+    });
+  });
+
   it('should throw an error if the timeout property is not parsable as a number', function (done) {
 
     server = http.createServer(function (req, res) {

Original file line number	Diff line number	Diff line change
`@@ -427,7 +427,7 @@ export default isHttpAdapterSupported && function httpAdapter(config) {`
`427`	`427`	`if (config.socketPath) {`
`428`	`428`	`options.socketPath = config.socketPath;`
`429`	`429`	`} else {`
`430`		`- options.hostname = parsed.hostname;`
	`430`	`+ options.hostname = parsed.hostname.startsWith("[") ? parsed.hostname.slice(1, -1) : parsed.hostname;`
`431`	`431`	`options.port = parsed.port;`
`432`	`432`	`setProxy(options, config.proxy, protocol + '//' + parsed.hostname + (parsed.port ? ':' + parsed.port : '') + options.path);`
`433`	`433`	`}`