write_hist_log: do not require ZLIB for non-server instances#2033
Merged
Conversation
Since `td->client_type` is always non-zero (CLI is 1, GUI is 2), the check `if (td->client_type)` in `init.c` always triggers, causing --write_hist_log to be unusable when ZLIB is not configured for standalone runs. By checking if the fio instance `is_backend`, ZLIB availability will be checked for fio running as server in server/client mode, and the check will be passed for fio running in standalone mode.
Contributor
Author
|
I manually tested it: In standalone mode, we can now get latency histogram logs correctly; in server/client mode, the server will produce this error message and get streamed to client stdout. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
write_hist_log: do not require ZLIB for non-server instances
Since
td->client_typeis always non-zero (CLI is 1, GUI is 2), the checkif (td->client_type)ininit.calways triggers, causing --write_hist_logto be unusable when ZLIB is not configured for standalone runs.
By checking if the fio instance
is_backend, ZLIB availability will bechecked for fio running as server in server/client mode, and the check
will be passed for fio running in standalone mode.
Fixes #1996
Signed-off-by: Alex Qiu [email protected]