backend: fix OOB access in usec_for_io() with DDIR_SYNC#2028
Merged
Conversation
When rate limiting is enabled, do_io() calls usec_for_io() to calculate delays. If the current operation is a sync (DDIR_SYNC), using it as an index into arrays sized DDIR_RWDIR_CNT (such as td->rate_bps) results in an out-of-bounds access. Guard the rate limiting check in do_io() with ddir_rw() to ensure it only applies to READ, WRITE, and TRIM operations. This fixes a UBSAN out-of-bounds error reported in usec_for_io(). Signed-off-by: Florian Mayer <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When rate limiting is enabled, do_io() calls usec_for_io() to calculate
delays.
If the current operation is a sync (DDIR_SYNC), using it as an index into
arrays sized DDIR_RWDIR_CNT (such as td->rate_bps) results in an
out-of-bounds access.
Guard the rate limiting check in do_io() with ddir_rw() to ensure it only
applies to READ, WRITE, and TRIM operations.
This fixes a UBSAN out-of-bounds error reported in usec_for_io().
Signed-off-by: Florian Mayer [email protected]