io_uring: ensure accurate real_file_size setup for full device access with PI enabled #1927
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… with PI enabled Fix real_file_size calculation when PI is enabled When PI is enabled, the extended LBA (lba_ext) should be used to calculate real_file_size instead of lba_size. This ensures FIO can access the entire device area correctly. Signed-off by: Suho Son <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When Protection Information (PI) is enabled on NVMe devices, the file size was incorrectly calculated using
data->lba_sizeinstead ofdata->lba_ext. This caused FIO to access only a portion of the device(e.g. 4096/(4096+64)=98.46%), leading to incomplete I/O coverage during tests.This patch updates the
real_file_sizecalculation logic to conditionally usedata->lba_extwhen available, and fall back todata->lba_sizeotherwise. This ensures that FIO correctly calculates the full storage capacity and accesses the entire device area when PI is enabled.Fixes
real_file_sizeassignment due to usinglba_sizeinstead oflba_ext