Repository navigation
improv(idempotency): consolidate internal implementation - #1642
Merged
am29d merged 2 commits intoAug 3, 2023
Merged
Conversation
1 of 2 tasks
Contributor
Author
|
Kudos, SonarCloud Quality Gate passed!
|
am29d
approved these changes
Aug 3, 2023
am29d
left a comment
Contributor
There was a problem hiding this comment.
Substantial refactor to make it easier for middy and wrapper to use the same logic. Great work!
am29d
deleted the
1508-maintenance-consolidate-idempotencyhandler-implementation
branch
August 3, 2023 14:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.








Description of your changes
This PR introduces a refactor of the
IdempotencyHandlerandmakeHandlerIdempotentMiddy middleware so that the latter uses logic from the former rather than duplicating logic.Prior to this PR the middleware was reimplementing some of the logic found in the
IdempotencyHandlerbecause at the time of implementing the handler its logic was not taking into account the request lifecycle that Middy middlewares use to handle requests.The PR adds some new methods/hooks to the handler so that most of the idempotency logic still resides in the handler. Some of the actions still need to be manual due to how Middy works, a different approach would require a complete refactor of the
IdempotencyHandlerclass.Related issues, RFCs
Issue number: #1508
Checklist
Breaking change checklist
Is it a breaking change?: NO
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.