Add aws distro version to sdk.version resource attributes.#69
Conversation
There was a problem hiding this comment.
Your overview comment is confusing:
This PR set telemetry.auto.version to be the version of aws-opentelemetry-distro pkg.
Actually, we are setting telemetry.sdk.version.
Although In Java, telemetry.distro.version resource attribute is being deprecated.
What is telemetry.distro.version? It's not referenced in this PR.
We don't find any related change in upstream. It is still being used, so we are not going to deprecate it in aws-opentelemetry-distro.
This is a bit of a confusing line of thought. It's not super clear why we are talking about deprecating things.
It would be helpful to explain a) what are these ResourceAttributes used for, b) what was the behaviour before, c) why it was a problem, and d) how this change solves that problem. In your testing, you should show a before and after.
Also why do we need to do this in Python, but not in Java?
2 participants
Issue #, if available:
In Java,
telemetry.auto.versionresource attribute is being deprecated (PR). However, We don't find any related change in upstream. It is still being used, so we are not going to deprecate it in aws-opentelemetry-distro for now. And we useaws-opentlemetry-distroversion with "-aws" post-fix to be thetelemetry.auto.version, which match with the Java implementation.Testing:
Tested resource attributed are generated:
Before the change:
After the change:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.