WIP 02 - Add Some Triggers #13
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ferruzzi
commented
Feb 12, 2025
airflow/models/deadline.py
Outdated
| log.info("MOCKED Getting %s :: %s", table_name, column_name) | ||
| return datetime(2024, 1, 1) | ||
|
|
||
| def dagrun_execution_date(self) -> datetime: |
Author
There was a problem hiding this comment.
execution_date was renamed logical_date at some point. I've updated my code here accordingly.
Collaborator
|
This Fork is only for AWS OSS Airflow team members to submit pull requests to be merged upstream to apache/airflow or to develop feature branches until they are ready for upstream submission. This PR has been verified to be from an allowed author and not affecting an upstream Airflow branch directly in this repository, this PR will be left open. |
ferruzzi
force-pushed
the
deadlines_feature/ferruzzi/01-add_deadline_to_dag_model
branch
from
b3524bf to
9e86b73
Compare
ferruzzi
force-pushed
the
deadlines_feature/ferruzzi/02-add_triggers
branch
from
0c77605 to
b7834a9
Compare
ferruzzi
force-pushed
the
deadlines_feature/ferruzzi/01-add_deadline_to_dag_model
branch
from
9e86b73 to
4305cb6
Compare
ferruzzi
force-pushed
the
deadlines_feature/ferruzzi/02-add_triggers
branch
from
b7834a9 to
691199f
Compare
ferruzzi
force-pushed
the
deadlines_feature/ferruzzi/02-add_triggers
branch
from
691199f to
98c32cf
Compare
vincbeck
approved these changes
Feb 24, 2025
seanghaeli
added a commit
that referenced
this pull request
Aug 7, 2025
author Sean Ghaeli <[email protected]> 1754492517 -0700 committer Sean Ghaeli <[email protected]> 1754608125 -0700 parent b22b1a6 author Sean Ghaeli <[email protected]> 1754492517 -0700 committer Sean Ghaeli <[email protected]> 1754608106 -0700 # This is a combination of 18 commits. # This is the 1st commit message: Shared client pool for base waiter and thread safe client pooling # This is the commit message #2: working smus test # This is the commit message #3: format ECS run_task API call correctly for env vars # This is the commit message #4: Make test filename equal to Dag ID # This is the commit message #5: Format env variables for ECS run_task correctly # This is the commit message #6: Have dag name match the test file name # This is the commit message #7: verbose logging # This is the commit message #8: with logging # This is the commit message #9: debugs on ecs executor # This is the commit message #10: wrap container overrides in a list according to docs # This is the commit message #11: no need to typecast string # This is the commit message #12: new logs # This is the commit message #13: name param must be defined in containeroverrides # This is the commit message #14: new logs # This is the commit message #15: Use correct ECS executor container name # This is the commit message #16: new logging # This is the commit message #17: remove unecessary logs not to be included in PR # This is the commit message #18: Remove redundant ECS executor logs cache aiobotocore client per trigger instance with async context manager Thread safe client pooling Thread safe client pooling type annotation for client pool dict type annotation for client pool dict
seanghaeli
added a commit
that referenced
this pull request
Aug 7, 2025
author Sean Ghaeli <[email protected]> 1754492517 -0700 committer Sean Ghaeli <[email protected]> 1754608125 -0700 parent b22b1a6 author Sean Ghaeli <[email protected]> 1754492517 -0700 committer Sean Ghaeli <[email protected]> 1754608106 -0700 # This is a combination of 18 commits. # This is the 1st commit message: Shared client pool for base waiter and thread safe client pooling # This is the commit message #2: working smus test # This is the commit message #3: format ECS run_task API call correctly for env vars # This is the commit message #4: Make test filename equal to Dag ID # This is the commit message #5: Format env variables for ECS run_task correctly # This is the commit message #6: Have dag name match the test file name # This is the commit message #7: verbose logging # This is the commit message #8: with logging # This is the commit message #9: debugs on ecs executor # This is the commit message #10: wrap container overrides in a list according to docs # This is the commit message #11: no need to typecast string # This is the commit message #12: new logs # This is the commit message #13: name param must be defined in containeroverrides # This is the commit message #14: new logs # This is the commit message #15: Use correct ECS executor container name # This is the commit message #16: new logging # This is the commit message #17: remove unecessary logs not to be included in PR # This is the commit message #18: Remove redundant ECS executor logs cache aiobotocore client per trigger instance with async context manager Thread safe client pooling Thread safe client pooling type annotation for client pool dict type annotation for client pool dict
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on #11
Add a couple of triggers as well as an example of how the dagrun kickoff code will use them to calculate the actual need-by date.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.