Loosen version sepcifier of importlib_resources #1808
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Similar to aws-cloudformation#1479, but there is now a version 2 and version 3, neither of the "breaking" changes affects the use in this project (of just loading text files) so is okay for us to use.
kddejong
approved these changes
Nov 30, 2020
PatMyron
reviewed
Nov 30, 2020
| 'pathlib2>=2.3.0;python_version<="3.4"', | ||
| 'importlib_resources~=1.0.2;python_version=="3.4"', | ||
| 'importlib_resources~=1.4;python_version<"3.7" and python_version!="3.4"', | ||
| 'importlib_resources>=1.4,<4;python_version<"3.7" and python_version!="3.4"', |
Contributor
There was a problem hiding this comment.
Does version 4 have breaking changes?
Contributor
Author
There was a problem hiding this comment.
Version 4 hasn't been released yet, 3.x is the current latest -- this is just being safe as we don't know what the breaking change will be when it comes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #1479, but there is now a version 2 and version 3, neither of the
"breaking" changes affects the use in this project (of just loading text files) so
is okay for us to use.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.