Add note for using structured types with functions#3128
Merged
medelman17 merged 2 commits intoaws-amplify:mainfrom May 28, 2021
camerondurham:patch-1
Merged
Add note for using structured types with functions#3128medelman17 merged 2 commits intoaws-amplify:mainfrom camerondurham:patch-1
medelman17 merged 2 commits intoaws-amplify:mainfrom
camerondurham:patch-1
Conversation
As a first-time Lambda, I was unfamiliar with the expected input format for these functions. This note adds a link to the relevant Lambda documentation. While the examples in this document are helpful for the general expected design, it is difficult to understand the important parts required to implement a correct lambda resolver for a GraphQL function. I added the note to help other developers using more strongly typed languages such as Golang, Java, and C# should they encounter this error. Thank you for considering this change!
akshbhu
approved these changes
May 24, 2021
Contributor
akshbhu
left a comment
akshbhu
left a comment
There was a problem hiding this comment.
Thanks for the Contribution
LGTM!!
Contributor
Author
|
@akshbhu Thanks for reviewing! From these docs, you may or may not have to manually kick off the CI to run, since it looks like a check isn't run yet? Sorry if this doesn't apply to how you do CI on this repo. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
Added a note to relevant Lambda documentation and pointed out requirements for using typed event input.
As a first-time Lambda, I was unfamiliar with the expected input format for these functions. This note adds a link to the relevant Lambda documentation. While the examples in this document are helpful for the general expected design, it is difficult to understand the important parts required to implement a correct lambda resolver for a GraphQL function. I added the note to help other developers using more strongly typed languages such as Golang, Java, and C# should they encounter this error.
Thank you for considering this change!
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.