Repository navigation
feat(angular): Add services prop and custom-sign-up example - #628
Conversation
🦋 Changeset detectedLatest commit: e61a7d3 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
This pull request introduces 1 alert when merging 764ddc6 into c749e50 - view on LGTM.com new alerts:
|
| @@ -0,0 +1,8 @@ | |||
| --- | |||
There was a problem hiding this comment.
Added two changesets because this PR because this PR does two different things. Let's see how #596 consumes this.
| @Input() autocomplete = 'new-password'; | ||
| @Input() disabled = false; | ||
| @Input() id: string; | ||
| @Input() fieldId: string = `amplify-field-${nanoid(12)}`; |
There was a problem hiding this comment.
Renamed this prop id to fieldId to prevent duplicate id html attribute values on screen, which breaks accessibility.
There was a problem hiding this comment.
Related, angular/angular#18877 -- this wouldn't be a problem if Angular support fragments.
ericclemmons
left a comment
ericclemmons
left a comment
There was a problem hiding this comment.
Nothing blocking, looking good!
| 'docs': patch | ||
| 'angular-example': patch | ||
| '@aws-amplify/ui-angular': patch | ||
| 'e2e': patch |
There was a problem hiding this comment.
Should docs, angular-example, & e2e be ignored?
There was a problem hiding this comment.
Yeah, I'm divided on this. Note that this is what shows up by default when you click the "add changeset" link from the bot and these will be ignored on changeset version or changeset publish as per .changeset/config.json.
I personally don't like the DX of having to remove these ignored packages manually, so I kept it as-is. Let's seee how this gets consumed in #596 and we can have a DX discussion based off that.
There was a problem hiding this comment.
🦋 error Error: Found mixed changeset wicked-cups-tie
🦋 error Found ignored packages: docs angular-example e2e
🦋 error Found not ignored packages: @aws-amplify/ui-angular
We do need to remove those unused packages. TIL! I'll just push something to main directly to fix that shortly.
| <amplify-checkbox | ||
| [errorMessage]="validationErrors.acknowledgement" | ||
| [hasError]="!!validationErrors.acknowledgement" | ||
| name="acknowledgement" | ||
| value="yes" | ||
| > | ||
| I agree with the Terms & Conditions | ||
| </amplify-checkbox> |
Sync amplify-ui to amplify-ui-staging
Issue #, if available:
Description of changes: Add
serviceprop toamplify-sign-up, which enables customers to provide their own validation services. Also addsamplify-checkboxcomponent for customers to use.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.