feat: scaffolding for improved pass-throughs in schema#3055
Merged
Conversation
hoffa
marked this pull request as ready for review
March 23, 2023 20:51
ssenchenko
approved these changes
Mar 23, 2023
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available
Description of changes
Scaffolding to partly address limitation (3) in #2645:
So instead of using the documentation from SAM, for pass-through properties we use the documentation straight from the source: from the actual property being passed-through to.
This means pass-through properties get accurate types, even for nested pass-throughs. Previously it would accept anything.
Before
After
Description of how you validated changes
Used schema modeline in VS Code, played around with templates that previously wouldn't have supported pass-throughs. With this change it shows the documentation straight from the source property.
Checklist
Examples?
Please reach out in the comments if you want to add an example. Examples will be
added to
sam initthrough aws/aws-sam-cli-app-templates.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.