refactor(s2n-quic-core): use core::net::SocketAddr #2913
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Since Rust 1.77
std::net::SocketAddrand related types have been available incore::net. This means we no longer need to gate some of the conversion methods we had for converting between our own socket address representations and thenet::SocketAddrtypes behind andstdfeature flag.I've also added a
Fromimpl forLocalAddressandRemoteAddress, as that may be useful in #2906Call-outs:
std::net::ToSocketAddrsremains instdso we can't remove the entirestd_conversionmodTesting:
Existing tests pass and ./scripts/test_no_std script passes
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.