Skip to content

Conversation

@WesleyRosenblum
Copy link
Contributor

Description of changes:

Since Rust 1.77 std::net::SocketAddr and related types have been available in core::net. This means we no longer need to gate some of the conversion methods we had for converting between our own socket address representations and the net::SocketAddr types behind and std feature flag.

I've also added a From impl for LocalAddress and RemoteAddress, as that may be useful in #2906

Call-outs:

std::net::ToSocketAddrs remains in std so we can't remove the entire std_conversion mod

Testing:

Existing tests pass and ./scripts/test_no_std script passes

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@WesleyRosenblum WesleyRosenblum requested a review from a team as a code owner December 10, 2025 22:06
@boquan-fang boquan-fang self-requested a review December 10, 2025 22:13
@boquan-fang boquan-fang merged commit 054a7dd into main Dec 10, 2025
134 checks passed
@boquan-fang boquan-fang deleted the WesleyRosenblum/corenetsocketaddr branch December 10, 2025 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants