opt(s2n-quic-dc): only read-lock once in happy path #2867
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes one of two read locks taken on the path secret map within handshake_with_entry, which is called for each outbound stream. In practice the double locking should be fairly cheap (just an atomic increment most of the time), but it's still a contended cache line so reducing operations on it should help.
maddeleine
approved these changes
Oct 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release Summary:
Resolved issues:
n/a
Description of changes:
This removes one of two read locks taken on the path secret map within handshake_with_entry, which is called for each outbound stream. In practice the double locking should be fairly cheap (just an atomic increment most of the time), but it's still a contended cache line so reducing operations on it should help.
Call-outs:
n/a
Testing:
Exercised by existing tests. Purely a (probably theoretical) performance optimization.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.