ci(dhat): upload dhat artifacts regardless of steps outcome #2850
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release Summary:
Resolved issues:
resolves #2817.
Description of changes:
This PR adds the option
continue-on-erro: truefor theRun clientstep in our CI. In this way, regardless of the outcome from therun-clientstep, dhat artifacts should always be prepared and uploaded to S3. The entire dhat job should fail if theRun clientstep fails.Call-outs:
N/A
Testing:
I opened another PR in #2851.
That PR has the exact code change with one more line:
It intentionally failed the
Run clientjob to test the code change:dhatartifacts should be uploaded to S3, and I have verified that in https://us-west-2.console.aws.amazon.com/s3/buckets/s2n-quic-ci-artifacts?region=us-west-2&bucketType=general&prefix=6a381411776129df99150a810595564dd4449815/dhat/&showversions=false. The artifacts are successfully uploaded.Check run client statusshould fail the entire job. I have verified that happened:https://github.com/aws/s2n-quic/actions/runs/18474446048/job/52635728821?pr=2851.
Hence, that should prove that this change works.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.