Skip to content

Conversation

@boquan-fang
Copy link
Contributor

@boquan-fang boquan-fang commented Oct 13, 2025

Release Summary:

Resolved issues:

resolves #2817.

Description of changes:

This PR adds the option continue-on-erro: true for the Run client step in our CI. In this way, regardless of the outcome from the run-client step, dhat artifacts should always be prepared and uploaded to S3. The entire dhat job should fail if the Run client step fails.

Call-outs:

N/A

Testing:

I opened another PR in #2851.

That PR has the exact code change with one more line:

      - name: Run client
        id: run-client
        working-directory: tools/memory-report
        continue-on-error: true
        run: |
          ./target/release/memory-report client > report.tsv
          exit 1

It intentionally failed the Run client job to test the code change:

  1. The dhat artifacts should be uploaded to S3, and I have verified that in https://us-west-2.console.aws.amazon.com/s3/buckets/s2n-quic-ci-artifacts?region=us-west-2&bucketType=general&prefix=6a381411776129df99150a810595564dd4449815/dhat/&showversions=false. The artifacts are successfully uploaded.
  2. The job should fail and the last step Check run client status should fail the entire job. I have verified that happened:
    https://github.com/aws/s2n-quic/actions/runs/18474446048/job/52635728821?pr=2851.

Hence, that should prove that this change works.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@boquan-fang boquan-fang marked this pull request as ready for review October 13, 2025 18:16
@boquan-fang boquan-fang requested a review from a team as a code owner October 13, 2025 18:16
Copy link
Contributor

@maddeleine maddeleine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Lgtm!

@boquan-fang boquan-fang merged commit 4bd8d3f into main Oct 13, 2025
133 checks passed
@boquan-fang boquan-fang deleted the continue-with-fail branch October 13, 2025 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CI Artifacts Not Uploaded if Previous Steps Failed

2 participants