feat(s2n-quic-dc): Add Unix domain socket sender/receiver #2842
Conversation
mehnazyunus
force-pushed
the
uds-communication
branch
from
744f00f to
71610de
Compare
mehnazyunus
force-pushed
the
uds-communication
branch
from
06c24b4 to
8daebcb
Compare
|
Looks like as of #2848 we'll need someone from @aws/s2n-core to review as well, requested @maddeleine for now. |
| Ok(()) => { | ||
| return Ok(()); | ||
| } | ||
| Err(nix::Error::EAGAIN) => { |
There was a problem hiding this comment.
Aren't you also going to get partial sends that you might need to handle? I don't see where you're checking the number of bytes sent.
There was a problem hiding this comment.
I'm pretty sure datagram sockets are either 'send everything' or 'send nothing' - but it would be good to confirm and probably add an assertion that any returned size matches what we expected to send.
There was a problem hiding this comment.
Yeah that would make sense, although eh, confirming that is kind of a pain. I suppose if this is between two processes I'm not sure a partial send could even occur.
There was a problem hiding this comment.
This stack overflow answer seems to imply that yes, if you can't fully send with a datagram socket, you get an error instead of a partial send.
3 participants
Release Summary:
Resolved issues:
n/a
Description of changes:
Creates a sender and receiver for Unix domain sockets. This handles a message along with a file descriptor as ancillary data. This functionality is required for reusing dcQUIC handshakes across application processes.
Call-outs:
Testing:
Added unit test.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.