generated from amazon-archives/__template_Apache-2.0
-
Notifications
You must be signed in to change notification settings - Fork 151
Open
Labels
Description
Security issue notifications
Problem:
We noticed that our max_total_test is consistently failing on AL2 X86_64 Kernel 5.10 machine. Turns out that our current way of calculation doesn't work for that machine:
s2n-quic/dc/s2n-quic-dc/src/msg/segment.rs
Lines 48 to 51 in 10c973d
| const MAX_TOTAL_IPV6: u16 = if cfg!(target_os = "linux") { | |
| // IPv6 doesn't include the IP header size in the calculation | |
| u16::MAX - UDP_HEADER_LEN | |
| } else { |
I found out the maximum payload size for that machine needs to include the 40 bytes IPV6 _HEADER_LEN. We do not know the exact reason behind such failure.
Need By Date:
N/A
Solution:
Figure out the reason of such failure and reconfigure the constant. For now, we make the constant more conservative by including the IPV6_HEADER_LEN in the calculation in #2727.
Requirements / Acceptance Criteria:
We should have the absolute maximum payload size for every platforms.