Fix Prometheus persistent volume mount ownership#22
Merged
jaypipes merged 1 commit intoaws:masterfrom Oct 23, 2019
stefanprodan:prom-pv-fix
Merged
Fix Prometheus persistent volume mount ownership#22jaypipes merged 1 commit intoaws:masterfrom stefanprodan:prom-pv-fix
jaypipes merged 1 commit intoaws:masterfrom
stefanprodan:prom-pv-fix
Conversation
Signed-off-by: stefanprodan <[email protected]>
jaypipes
approved these changes
Oct 23, 2019
Contributor
jaypipes
left a comment
jaypipes
left a comment
There was a problem hiding this comment.
Changes look good. Would be great to get a short description of how the changes fix the issue at hand, though. Something like "Mounts data volume in initContainers with specific non-root user ownership and runs the containers which need access to the volume as that UID."
jaypipes
approved these changes
Oct 23, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: #21 by mounting the PV in an init container that sets the ownership to the UID used by the Prometheus container.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.