feat(node): support node 20 in tasks #581
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hayemaxi
force-pushed
the
node10
branch
14 times, most recently
from
345c5ff to
6229150
Compare
|
@hayemaxi please review this PR and merge... we are waiting for these changes merged and for the new release... so that we can avoid the warning Awsshellscriot@1 support node 10 end of life |
Addresses aws#566. Use Node 20 using microsoft guidance: https://learn.microsoft.com/en-us/azure/devops/extend/develop/add-build-task?view=azure-devops#q-how-can-i-upgrade-my-custom-task-to-the-latest-node Keep Node 10 as a fallback. However, we are still building the node10 with esbuild to ensure backwards compatibility. In the future, we can consider building for a higher node version only. Adding support requires a hacky patch to fix shell.js, which doesn't support bundlers. Mitigates the issue described in aws#539 Credit to ivanduplenskikh: https://github.com/ivanduplenskikh/aws-toolkit-azure-devops/pull/1 Co-authored-by: Ivan Duplenskikh <[email protected]>
nkomonen-amazon
approved these changes
Dec 2, 2024
|
@nkomonen-amazon thanks for the quick around reviewing... @hayemaxi please merge this and release the new version |
|
@hayemaxi thanks for the quick review and merging the PR |
|
@hayemaxi Please do release for the latest changes |
|
@hayemaxi when we can expect the new version of release with these changes ? |
Contributor
Author
|
The changes have been released in v1.18.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use Node 20 using microsoft guidance: https://learn.microsoft.com/en-us/azure/devops/extend/develop/add-build-task?view=azure-devops#q-how-can-i-upgrade-my-custom-task-to-the-latest-node
Keep Node 10 as a fallback.
Adding support requires a hacky patch to fix shell.js, which doesn't support bundlers.
Mitigates the issue described in #539
Addresses #566
Credit to ivanduplenskikh: https://github.com/ivanduplenskikh/aws-toolkit-azure-devops/pull/1
Checklist
npm run newChangeLicense
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.