Repository navigation
fix(iceberg): too many open partitions by sorting inserts - #3294
Merged
Merged
Conversation
…cols when inserting into a partitioned iceberg table, the select query now includes an order by on the partition columns so iceberg can close partition writers sequentially instead of keeping them all open at once. this prevents the ICEBERG_TOO_MANY_OPEN_PARTITIONS error that happens with many distinct partition combinations.
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
knQzx
changed the title
Contributor
Author
|
all checks are passing, ready for review when you get a chance |
kukushking
approved these changes
Apr 7, 2026
kukushking
left a comment
kukushking
left a comment
Collaborator
There was a problem hiding this comment.
Thanks, looks great. I've spotted that identifier sanitization is missing in the module but that's a separate issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_merge_icebergICEBERG_TOO_MANY_OPEN_PARTITIONSerrorday(ts)by extracting the underlying column name for orderingTest plan
_extract_column_from_partition_transformand_build_order_by_clausehelper functionspartition_colsparameter cover the end-to-end flowfixes #3222