Skip to content

s3: Adds customization to disable s3 auto gzip decode#748

Merged
skotambkar merged 4 commits into
masterfrom
disableS3AutoGZIPDecode
Sep 30, 2020
Merged

s3: Adds customization to disable s3 auto gzip decode#748
skotambkar merged 4 commits into
masterfrom
disableS3AutoGZIPDecode

Conversation

@skotambkar
Copy link
Copy Markdown
Contributor

@skotambkar skotambkar commented Sep 23, 2020 •
edited
Loading

Adds customization to disable s3 auto gzip decode

  • Adds codegen customization for AWS Config field to set transport's DisableCompression to true.
  • Generate code change for s3/api_client.go

@skotambkar skotambkar changed the base branch from master to feature/SmithyAPIClient September 23, 2020 09:59
@skotambkar skotambkar requested a review from jasdel September 23, 2020 10:00
jasdel
jasdel suggested changes Sep 23, 2020
View reviewed changes
Comment thread ...y-aws-go-codegen/src/main/java/software/amazon/smithy/aws/go/codegen/AddAwsConfigFields.java Outdated
Comment thread service/s3/api_client.go Outdated
@skotambkar skotambkar force-pushed the disableS3AutoGZIPDecode branch from d087fc3 to b8bee42 Compare September 23, 2020 18:06
@skotambkar skotambkar requested review from jasdel and removed request for jasdel September 23, 2020 18:48
@skotambkar skotambkar force-pushed the disableS3AutoGZIPDecode branch from 3ab621e to fe40393 Compare September 23, 2020 21:27
@skotambkar skotambkar requested a review from jasdel September 23, 2020 21:52
jasdel
jasdel reviewed Sep 23, 2020
View reviewed changes
Comment thread service/internal/customizations/accept_encoding_gzip_test.go
@skotambkar skotambkar force-pushed the disableS3AutoGZIPDecode branch from fe40393 to fc9c511 Compare September 23, 2020 23:55
@skotambkar skotambkar requested a review from jasdel September 24, 2020 00:09
@skotambkar skotambkar force-pushed the disableS3AutoGZIPDecode branch 4 times, most recently from eef5ae9 to 7af0dbc Compare September 24, 2020 22:16
@skmcgrail skmcgrail force-pushed the feature/SmithyAPIClient branch from da6cee6 to 2f7dccf Compare September 24, 2020 22:30
Base automatically changed from feature/SmithyAPIClient to master September 29, 2020 01:53
@skotambkar skotambkar force-pushed the disableS3AutoGZIPDecode branch from 7af0dbc to e32e296 Compare September 30, 2020 08:47
@skotambkar skotambkar force-pushed the disableS3AutoGZIPDecode branch from e32e296 to 897dfb9 Compare September 30, 2020 08:50
@skotambkar skotambkar requested a review from jasdel September 30, 2020 18:37
@skotambkar skotambkar merged commit edf4143 into master Sep 30, 2020
@skotambkar skotambkar deleted the disableS3AutoGZIPDecode branch September 30, 2020 21:15
@goodspark goodspark mentioned this pull request Mar 27, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@skmcgrail skmcgrail Awaiting requested review from skmcgrail

1 more reviewer

@jasdel jasdel jasdel approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@skotambkar @jasdel