This repository was archived by the owner on Jul 31, 2025. It is now read-only.
aws: Add config option to unmarshal API response header maps to normalized lower case map keys#3033
Merged
skmcgrail merged 12 commits intoaws:masterfrom Jan 7, 2020
Merged
Conversation
jasdel
suggested changes
Dec 20, 2019
skotambkar
reviewed
Dec 23, 2019
skotambkar
reviewed
Dec 23, 2019
skotambkar
reviewed
Dec 23, 2019
skotambkar
reviewed
Dec 23, 2019
skotambkar
reviewed
Dec 23, 2019
skmcgrail
force-pushed
the
s3/headers
branch
from
40078df to
9ce78b9
Compare
skotambkar
reviewed
Dec 26, 2019
skotambkar
reviewed
Dec 26, 2019
skotambkar
approved these changes
Dec 26, 2019
Contributor
skotambkar
left a comment
skotambkar
left a comment
There was a problem hiding this comment.
Looks good, have minor suggestions.
jasdel
added
the
needs-review
jasdel
suggested changes
Jan 2, 2020
Contributor
jasdel
left a comment
jasdel
left a comment
There was a problem hiding this comment.
I think we should consider if normalized headers should apply to HTTP header marshal, not just unmarshal.
Also CHANGELOG_PENDING would be good for this, calling out fixes to related issues.
jasdel
removed
the
needs-review
… contain user input when sent or received from a service.
jasdel
suggested changes
Jan 6, 2020
jasdel
approved these changes
Jan 6, 2020
Contributor
|
Would be good to add CHANGELOG_PENDING.md entry |
skmcgrail
changed the title
skmcgrail
changed the title
aws-sdk-go-automation
pushed a commit
that referenced
this pull request
Jan 7, 2020
=== ### Service Client Updates * `service/AWSMigrationHub`: Updates service API, documentation, and paginators * `service/codebuild`: Updates service API and documentation * Add encryption key override to StartBuild API in AWS CodeBuild. * `service/xray`: Updates service documentation * Documentation updates for xray ### SDK Enhancements * `aws`: Add configuration option enable the SDK to unmarshal API response header maps to normalized lower case map keys. ([#3033](#3033)) * Setting `aws.Config.LowerCaseHeaderMaps` to `true` will result in S3's X-Amz-Meta prefixed header to be unmarshaled to lower case Metadata member's map keys. ### SDK Bugs * `aws/ec2metadata` : Reduces request timeout for EC2Metadata client along with maximum number of retries ([#3066](#3066)) * Reduces latency while fetching response from EC2Metadata client running in a container to around 3 seconds * Fixes [#2972](#2972)
Merged
aws-sdk-go-automation
added a commit
that referenced
this pull request
Jan 7, 2020
Release v1.27.2 (2020-01-07) === ### Service Client Updates * `service/AWSMigrationHub`: Updates service API, documentation, and paginators * `service/codebuild`: Updates service API and documentation * Add encryption key override to StartBuild API in AWS CodeBuild. * `service/xray`: Updates service documentation * Documentation updates for xray ### SDK Enhancements * `aws`: Add configuration option enable the SDK to unmarshal API response header maps to normalized lower case map keys. ([#3033](#3033)) * Setting `aws.Config.LowerCaseHeaderMaps` to `true` will result in S3's X-Amz-Meta prefixed header to be unmarshaled to lower case Metadata member's map keys. ### SDK Bugs * `aws/ec2metadata` : Reduces request timeout for EC2Metadata client along with maximum number of retries ([#3066](#3066)) * Reduces latency while fetching response from EC2Metadata client running in a container to around 3 seconds * Fixes [#2972](#2972)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds support for normalizing AWS REST encoded/decoded headers. This resolves an outstanding customer ask #445 which documents the behavior of both Go
net/httplayer canonicalizing headers that are received in HTTP responses, in addition to the AWS SDK also enforcing that these returned headers be canonicalized as well. Enabling this flag will result in these types of headers being sent as lower-cased to AWS services, and responses targeting the header location will have the headers lower-cased during unmarshaling.