Repository navigation
Update the "Using CMake exports with AWS sdk for C++" #1307
Description
The documentation points to https://aws.amazon.com/fr/blogs/developer/using-cmake-exports-with-the-aws-sdk-for-c/ which suggests to use find_package(aws-sdk-cpp) while from what I gathered we are now supposed to use find_package(AWSSDK) ?
It would also be nice if the exported target were namespaced with AWS::. This is already the case for a few targets such as AWS::aws-c-common or the lambda runtime AWS::aws-lambda-runtime.
Currently we have to use either the non-namespaced targets (which has known issues in cmake, as if the target doesnt exist the configuration will not fail) or ${AWSSDK_LINK_LIBRARIES} which does not give any flexibility.
I tried modifying the do_packaging macro to use namespace (add NAMESPACE AWS:: here https://github.com/aws/aws-sdk-cpp/blob/master/cmake/utilities.cmake#L70 and here https://github.com/aws/aws-sdk-cpp/blob/master/cmake/utilities.cmake#L88 ).
And it seems to work fine so far.
Activity
KaibaLopez commentedon Jan 17, 2020
First, you're right, we should update that, thanks for pointing it out to us.
The rest would take a bit more time and discussion but does make sense, could you make a pull request with the changes you made?
dblock commentedon Mar 5, 2020
I PRed awsdocs/aws-cpp-developer-guide#37 and awsdocs/aws-doc-sdk-examples#1022 that should cover the documentation changes described here.
github-actions commentedon Mar 6, 2021
Greetings! Sorry to say but this is a very old issue that is probably not getting as much attention as it deservers. We encourage you to check if this is still an issue in the latest release and if you find that this is still a problem, please feel free to open a new one.