Fix ppc64le; Improve platform detection#2926
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2926 +/- ##
==========================================
- Coverage 78.21% 78.21% -0.01%
==========================================
Files 690 690
Lines 118737 118737
Branches 16680 16679 -1
==========================================
- Hits 92876 92873 -3
- Misses 24972 24975 +3
Partials 889 889 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
justsmth
force-pushed
the
update-platform-detection
branch
4 times, most recently
from
January 2, 2026 17:39
9eb1abb to
d6b9afd
Compare
justsmth
force-pushed
the
update-platform-detection
branch
from
January 2, 2026 22:09
d6b9afd to
95885f9
Compare
justsmth
changed the title
justsmth
marked this pull request as ready for review
January 5, 2026 13:59
torben-hansen
previously approved these changes
Jan 5, 2026
| #define OPENSSL_STATIC_ASSERT(cond, error) AWSLC_STATIC_ASSERT_ADD_ERROR(cond, error) | ||
|
|
||
| // Sanity check of "target.h": OPENSSL_64_BIT/OPENSSL_32_BIT must match actual pointer size | ||
| #if defined(OPENSSL_64_BIT) |
Contributor
There was a problem hiding this comment.
One comment on this is that these tests are duplicated many many times per build because this code is included in quite a few compilation units. Not blocking, just wanted to mention it.
samuel40791765
previously approved these changes
Jan 5, 2026
justsmth
enabled auto-merge (squash)
January 5, 2026 20:36
justsmth
dismissed stale reviews from samuel40791765 and torben-hansen
via
January 5, 2026 20:52
e66db72
justsmth
force-pushed
the
update-platform-detection
branch
4 times, most recently
from
January 5, 2026 21:43
b756ced to
83140a1
Compare
justsmth
force-pushed
the
update-platform-detection
branch
from
January 5, 2026 21:48
83140a1 to
c650a2b
Compare
samuel40791765
approved these changes
Jan 6, 2026
torben-hansen
approved these changes
Jan 6, 2026
EliahKagan
added a commit
to EliahKagan/gitoxide
that referenced
this pull request
Jan 21, 2026
This fixes the core issue in GitoxideLabs#2338 where powerpc64le builds were broken, by upgrading the transitive `aws-lc-rs` dependency to 1.15.3, and thus its `aws-lc-sys` dependency to 0.36.0. Those versions contain the fix in aws/aws-lc#2926 for the platform detection bug aws/aws-lc-rs#980 that caused the build failure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues:
Addresses: aws/aws-lc-rs#980
Description of changes:
Testing:
All existing CI jobs (including those for cross-compilation) pass.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.