Repository navigation
Commit d3a4930
authored
Honor IncludeCategory in the JSON log format (#2474)
* Honor IncludeCategory in the JSON log format
In text format the ILogger category is written on every line when
LambdaLoggerOptions.IncludeCategory is true (the default), but the JSON
branch of LambdaILogger.Log never emitted the category, so migrating a
function from text to JSON logging silently lost it with no way to opt
back in (#2469).
When IncludeCategory is set, prepend a {Category} placeholder to the
message template and supply the category value, so it surfaces as a
queryable property in the JSON record instead of being dropped. Text
format is unchanged, and JSON output is unchanged when IncludeCategory
is false.
Fixes #2469
* chore: add change file for logging category fix
* fix: prepend category as plain text, not a template placeholder
Copilot's review on this PR caught a real issue: prepending a {Category}
placeholder to honor IncludeCategory in JSON mode makes the formatter's
positional-argument detection treat the whole template as named, which
can shift how a caller's own {0}/{1} placeholders line up with their
values. Prepend the category as literal text instead, same as the text
format already does.
Updated the two category tests and added one covering a positional
template to confirm it stays untouched. All 17 tests pass locally on
net8.0 and net10.0.
* chore: restore the original line endings in LambdaILogger.cs
The first commit normalized the whole file to CRLF where upstream has
mixed endings, so the diff read 74 changed lines when only 11 lines
actually change. Content is unchanged: git diff -w against the previous
commit is empty.1 parent e41f33f commit d3a4930
3 files changed
Lines changed: 135 additions & 0 deletions
File tree
- .autover/changes
- Libraries
- src/Amazon.Lambda.Logging.AspNetCore
- test/Amazon.Lambda.Logging.AspNetCore.Tests
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
75 | 75 | | |
76 | 76 | | |
77 | 77 | | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
78 | 89 | | |
79 | 90 | | |
80 | 91 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
574 | 574 | | |
575 | 575 | | |
576 | 576 | | |
| 577 | + | |
| 578 | + | |
| 579 | + | |
| 580 | + | |
| 581 | + | |
| 582 | + | |
| 583 | + | |
| 584 | + | |
| 585 | + | |
| 586 | + | |
| 587 | + | |
| 588 | + | |
| 589 | + | |
| 590 | + | |
| 591 | + | |
| 592 | + | |
| 593 | + | |
| 594 | + | |
| 595 | + | |
| 596 | + | |
| 597 | + | |
| 598 | + | |
| 599 | + | |
| 600 | + | |
| 601 | + | |
| 602 | + | |
| 603 | + | |
| 604 | + | |
| 605 | + | |
| 606 | + | |
| 607 | + | |
| 608 | + | |
| 609 | + | |
| 610 | + | |
| 611 | + | |
| 612 | + | |
| 613 | + | |
| 614 | + | |
| 615 | + | |
| 616 | + | |
| 617 | + | |
| 618 | + | |
| 619 | + | |
| 620 | + | |
| 621 | + | |
| 622 | + | |
| 623 | + | |
| 624 | + | |
| 625 | + | |
| 626 | + | |
| 627 | + | |
| 628 | + | |
| 629 | + | |
| 630 | + | |
| 631 | + | |
| 632 | + | |
| 633 | + | |
| 634 | + | |
| 635 | + | |
| 636 | + | |
| 637 | + | |
| 638 | + | |
| 639 | + | |
| 640 | + | |
| 641 | + | |
| 642 | + | |
| 643 | + | |
| 644 | + | |
| 645 | + | |
| 646 | + | |
| 647 | + | |
| 648 | + | |
| 649 | + | |
| 650 | + | |
| 651 | + | |
| 652 | + | |
| 653 | + | |
| 654 | + | |
| 655 | + | |
| 656 | + | |
| 657 | + | |
| 658 | + | |
| 659 | + | |
| 660 | + | |
| 661 | + | |
| 662 | + | |
| 663 | + | |
| 664 | + | |
| 665 | + | |
| 666 | + | |
| 667 | + | |
| 668 | + | |
| 669 | + | |
| 670 | + | |
| 671 | + | |
| 672 | + | |
| 673 | + | |
| 674 | + | |
| 675 | + | |
| 676 | + | |
| 677 | + | |
| 678 | + | |
| 679 | + | |
| 680 | + | |
| 681 | + | |
| 682 | + | |
| 683 | + | |
| 684 | + | |
| 685 | + | |
| 686 | + | |
| 687 | + | |
| 688 | + | |
| 689 | + | |
577 | 690 | | |
578 | 691 | | |
579 | 692 | | |
| |||
0 commit comments