Update README to specify JDK8 or greater, and update .travis.yml to use JDK8#57
Merged
SalusaSecondus merged 2 commits intoaws:masterfrom Nov 9, 2018
johnwalker:travis
Merged
Update README to specify JDK8 or greater, and update .travis.yml to use JDK8#57SalusaSecondus merged 2 commits intoaws:masterfrom johnwalker:travis
SalusaSecondus merged 2 commits intoaws:masterfrom
johnwalker:travis
Conversation
Add a blurb about which JDK version is needed to use the library.
Update the JDK versions Travis uses for CI for aws-dynamodb-encryption-java. Today, these tests fail because the minimum supported version is JDK7.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates the readme to specify the JDK version used by the project to be at least JDK8. Let me know if we need JDK7 builds after all, my opinion is just based on what is inside the pom.xml and other build configurations.
Tested JDK7 using Travis - test failed, due to "[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile) on project aws-dynamodb-encryption-java: Fatal error compiling: invalid target release: 1.8 -> [Help 1]"
Updated .travis.yml to JDK8 and tested on Travis - tests passed
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.