fix(sdk): Use current time for onOperationAttemptStart startTimestamp#718
Merged
Merged
Conversation
SilanHe
changed the title
Replace the startTimestamp derived from stepData (the checkpoint record) with new Date() so that plugins receive the actual wall-clock time when each attempt begins executing. Updated tests to assert startTimestamp is a recent Date instance.
SilanHe
force-pushed
the
fix/use-current-time-for-attempt-start-timestamp
branch
from
July 14, 2026 22:49
19d9823 to
1104e4a
Compare
SilanHe
marked this pull request as ready for review
July 14, 2026 23:12
zhongkechen
approved these changes
Jul 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Replace the startTimestamp derived from stepData (the checkpoint record) with new Date() so that plugins receive the actual wall-clock time when each attempt begins executing.
Updated tests to assert startTimestamp is a recent Date instance.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.