ci(otel): Enable cloud deployment and strengthen span asse…#684
Merged
Conversation
…rtions Remove localOnly flag from all OTel examples to enable cloud deployment and integration testing. Update otel-invoke to target otel-basic-steps (which matches the *-NodeJS* IAM permission pattern) instead of a non-existent invoke-target function. Update retry-steps to use createRetryStrategy from the SDK. Strengthen test assertions to verify specific span names, types, parent-child hierarchy, and attributes rather than just counts.
SilanHe
force-pushed
the
otel-examples-cloud-enable
branch
from
July 3, 2026 18:45
b4a40b9 to
e3e2591
Compare
…rtions Remove localOnly flag from all OTel examples to enable cloud deployment and integration testing. Update otel-invoke to target otel-basic-steps (which matches the *-NodeJS* IAM permission pattern). Update retry-steps to use createRetryStrategy from the SDK. Refactor tests to read spans from the exported getSerializedSpans() function after runner.run() returns (local) or from result.spans (cloud). This ensures the final invocation span is always included, giving consistent exact span counts across environments. Strengthen test assertions to verify specific span names, types, parent-child hierarchy, and attributes rather than just counts.
SilanHe
force-pushed
the
otel-examples-cloud-enable
branch
3 times, most recently
from
July 3, 2026 22:51
831e861 to
303e619
Compare
SilanHe
force-pushed
the
otel-examples-cloud-enable
branch
from
July 3, 2026 23:20
303e619 to
c3ea9a5
Compare
SilanHe
force-pushed
the
otel-examples-cloud-enable
branch
from
July 6, 2026 20:10
410ff86 to
828792c
Compare
…helper Add type guard in assertSpanAttributes to skip metadata namespace entries that are not objects (e.g. plain strings like the function name), preventing TypeError when using the 'in' operator.
SilanHe
force-pushed
the
otel-examples-cloud-enable
branch
from
July 6, 2026 21:54
92257d4 to
72dc29a
Compare
SilanHe
marked this pull request as ready for review
July 6, 2026 21:54
Contributor
Author
|
All the tests have passed previously, I just removed an extra file from the PR (mise.toml) that shouldn't have been included. https://github.com/aws/aws-durable-execution-sdk-js/actions/runs/28824831798/job/85486889703?pr=684 |
wangyb-A
approved these changes
Jul 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…rtions
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.