chore(otel): Remove RETRYING from AttemptEndInfoOutcome#679
Merged
Conversation
Replace AttemptEndInfoOutcome.RETRYING with FAILED for attempt-level outcomes. Whether a retry follows is already conveyed by the nextAttemptDelaySeconds field on AttemptEndInfo, making a separate RETRYING outcome redundant. This simplifies the attempt outcome to a binary SUCCEEDED/FAILED.
The nextAttemptDelaySeconds field on AttemptEndInfo was only meaningful when RETRYING was a distinct outcome. Now that attempts simply report FAILED, this field is no longer needed in the plugin interface. The internal checkpoint still tracks retry delay independently.
SilanHe
changed the title
SilanHe
marked this pull request as ready for review
July 2, 2026 18:38
zhongkechen
previously approved these changes
Jul 2, 2026
Contributor
|
Tests failed |
ParidelPooya
reviewed
Jul 2, 2026
ParidelPooya
previously approved these changes
Jul 2, 2026
zhongkechen
approved these changes
Jul 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace AttemptEndInfoOutcome.RETRYING with FAILED for attempt-level outcomes. Also removes the nextAttemptDelaySeconds field.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.