fix(testing-sdk): bump to 1.1.2 and publish core SDK peer-compat fix#678
Merged
Conversation
The published `@aws/[email protected]` declares a peer dependency of `@aws/durable-execution-sdk-js@^1.0.1`, which fails to resolve against the core SDK v2.0.0 (issue #674). The source was already widened to `*`, but the version was never bumped, so the fix could not be republished over the existing 1.1.1 on npm. Changes: - Bump the testing package version 1.1.1 -> 1.1.2 so the already-correct `*` peer range can be published to the registry. - Add a regression test (src/__tests__/peer-compatibility.test.ts) that reads both manifests off disk and asserts the core SDK's current version satisfies the declared peer range. Workspace symlinking masks this class of bug, so the test guards against it without needing a registry install. - Add `semver` and `@types/semver` devDependencies used by the test. Verified: full testing suite passes (1167 passed) with coverage thresholds held; the test fails as expected when the peer range is reverted to `^1.0.1`. Fixes #674
yaythomas
approved these changes
Jul 2, 2026
yaythomas
left a comment
yaythomas
left a comment
Contributor
There was a problem hiding this comment.
- Core SDK version at PR head is 2.0.0, testing peer range is already "*", testing version bumped 1.1.1 → 1.1.2 in both package.json and package-lock.json. All consistent with the PR description.
- Issue #674 root cause confirmed: published 1.1.1 shipped peer ^1.0.1, which ERESOLVEs against core 2.0.0. Source was widened to * in a prior commit (1e60aee) but never republished because the version was not bumped. This PR does the bump so the fix can ship.
- The regression test genuinely guards the bug: satisfies("2.0.0", "^1.0.1") is false
- semver / @types/semver are added as devDependencies only, not runtime. Correct.
ParidelPooya
marked this pull request as ready for review
July 2, 2026 17:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The published
@aws/[email protected]declares a peer dependency of@aws/durable-execution-sdk-js@^1.0.1, which fails to resolve against the core SDK v2.0.0 (issue #674). The source was already widened to*, but the version was never bumped, so the fix could not be republished over the existing 1.1.1 on npm.Changes:
*peer range can be published to the registry.semverand@types/semverdevDependencies used by the test.Verified: full testing suite passes (1167 passed); the test fails as expected when the peer range is reverted to
^1.0.1.Issue #, if available: #674
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.