Codecov Report

Merging #3430 into develop will increase coverage by <.01%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #3430      +/-   ##
===========================================
+ Coverage     94.4%   94.41%   +<.01%     
===========================================
  Files          169      169              
  Lines        13252    13252              
===========================================
+ Hits         12511    12512       +1     
+ Misses         741      740       -1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2782bfd...9d36245. Read the comment docs.

Any status on this? Currently our CI/CD is blocked on it without downgrading our image to python@2.

@stealthycoin I can add that in a separate PR or in this one -- imo orthogonal to allowing new pyyaml though :)

For the impatient:

pip3 install --user git+https://github.com/asottile/aws-cli.git@allow_new_pyyaml

fwiw, there's a single failure in python3.7:

FAIL: test_does_not_hard_fail_on_invalid_signature (tests.unit.customizations.cloudtrail.test_validation.TestDigestTraverser)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/travis/build/asottile/aws-cli/tests/unit/customizations/cloudtrail/test_validation.py", line 728, in test_does_not_hard_fail_on_invalid_signature
    calls[0]['message'])
AssertionError: 'Dige[48 chars]D: Incorrect padding' != 'Dige[48 chars]D: Invalid base64-encoded string: length canno[28 chars]of 4'
- Digest file	s3://1/20150810T000000Z.json.gz	INVALID: Incorrect padding
+ Digest file	s3://1/20150810T000000Z.json.gz	INVALID: Invalid base64-encoded string: length cannot be 1 more than a multiple of 4

@asottile Yep I see that now too. I ran in 3.6 on accident. So that needs to get figured out before this can be merged.

Edit: I guess that would be a blocking issue on adding the 3.7 travis entries not really this PR.

@stealthycoin why does that block this? pyyaml 3.13 works fine for the other supported python versions today

@asottile It isn't. I am currently running the branch through it through integration tests.

@stealthycoin any updates on this? not sure why this is taking so long -- 3.13 is the same codebase as 3.12 it's just a version bump from the pyyaml side

How about EB CLI? Is that changed to use pyyaml 3.13 when installed with pip? Cause I am still getting an error when using a docker python image on circleci with python 3.7.0.