Skip to content

Allow the brand new 4.x release of pyyaml#3414

Closed
asottile wants to merge 1 commit intoaws:developfrom
asottile:allow_new_pyyaml
Closed

Allow the brand new 4.x release of pyyaml#3414
asottile wants to merge 1 commit intoaws:developfrom
asottile:allow_new_pyyaml

Conversation

@asottile
Copy link
Copy Markdown
Contributor

@asottile asottile commented Jun 27, 2018

the most important "breaking" change of pyyaml 4.x is the move to "safe by default" -- I browsed awscli's usage of pyyaml and it looks like the safe loader is already being used

@asottile
Copy link
Copy Markdown
Contributor Author

asottile commented Jun 27, 2018

(I initially ran into this from the following warning from pip):

awscli 1.15.46 has requirement PyYAML<=3.12,>=3.10, but you'll have pyyaml 4.1 which is incompatible.

@codecov-io
Copy link
Copy Markdown

codecov-io commented Jun 27, 2018 •
edited
Loading

Codecov Report

Merging #3414 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           develop   #3414   +/-   ##
=======================================
  Coverage     94.4%   94.4%           
=======================================
  Files          169     169           
  Lines        13223   13223           
=======================================
  Hits         12483   12483           
  Misses         740     740

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce93d2a...f5611b0. Read the comment docs.

@hugovk
Copy link
Copy Markdown
Contributor

hugovk commented Jun 27, 2018

👍

This should also fix problems installing awscli on Python 3.7: yaml/pyyaml#126.

(Python 3.7 is due for release today, 2018-06-27: https://www.python.org/dev/peps/pep-0537/)

How about adding 3.7-dev to .travis.yml and py37 to tox.ini in this PR?

@hugovk hugovk mentioned this pull request Jun 27, 2018
Merged
@asottile
Copy link
Copy Markdown
Contributor Author

asottile commented Jun 27, 2018

the problem with travis-ci's 3.7-dev is it's 3.7.0a4 which is quite different from the 3.7.0 final that's going to be released this week. most of this is due to travis being stuck on trusty (3.7.0 will require libssl 1.0.2, whereas trusty only has 1.0.1)

@asottile
Copy link
Copy Markdown
Contributor Author

asottile commented Jul 3, 2018

well it got pulled, wonderful!

@asottile asottile closed this Jul 3, 2018
@asottile asottile deleted the allow_new_pyyaml branch July 3, 2018 03:26
@hugovk hugovk mentioned this pull request Jul 3, 2018
Closed
@ViktorHaag ViktorHaag mentioned this pull request Jul 3, 2018
Closed
@tony tony mentioned this pull request Jul 3, 2018
Closed
@asottile asottile mentioned this pull request Jul 6, 2018
Merged
@asottile
Copy link
Copy Markdown
Contributor Author

asottile commented Jul 6, 2018

I've opened #3430 for the just-released 3.13

thoward-godaddy pushed a commit to thoward-godaddy/aws-cli that referenced this pull request Feb 12, 2022
@CoshUS
fix: Changed sam-acc Command to sam (aws#3414)
0d84842
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@hugovk hugovk hugovk approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@asottile @codecov-io @hugovk