fix(cloud-assembly-schema/cli): manifest validation fails on Node <18.17#61
Merged
Conversation
It looks like `jsonschema 1.5.0` contains changes that are not compatible with Node 16. Hold back the version to 1.4.1.
rix0rrr
had a problem deploying
to
integ-approval
February 18, 2025 23:57 — with
GitHub Actions
Failure
aws-cdk-automation
enabled auto-merge
February 18, 2025 23:58
Signed-off-by: github-actions <[email protected]>
aws-cdk-automation
had a problem deploying
to
integ-approval
February 19, 2025 00:10 — with
GitHub Actions
Failure
rix0rrr
disabled auto-merge
February 19, 2025 00:23
mrgrain
pushed a commit
to go-to-k/aws-cdk-cli
that referenced
this pull request
Jun 22, 2026
…11 (aws#1529) ## P0 Fix: npm ci fails on npm 11 with [email protected] Fixes aws/aws-cdk#37870 ### Problem `npm ci` fails on npm 11 with `Missing: [email protected] from lock file` when using [email protected]. The root cause is that `@aws-cdk/cloud-assembly-api` declares `jsonschema: "~1.4.1"` in its dependencies, but aws-cdk-lib bundles `[email protected]` at the top level. The tilde range `~1.4.1` excludes 1.5.0, so npm 11's stricter lock file validation rejects the mismatch. ### Fix Widen the range from `~1.4.1` to `^1.5.0`. The original tilde pin was introduced in PR aws#61 to work around `[email protected]` being incompatible with Node < 18.17. Since CDK has dropped Node 18 support entirely, this constraint no longer applies. ### Context - Rico noted in aws/aws-cdk#37717 that unbundling `cloud-assembly-api` is not viable because it's not a jsii module. PR #37721 (community attempt at unbundling) confirmed this with build failures. - This was identified as the other viable fix option: widen the range at the source in this repo. - Original pin reason (PR aws#61): `[email protected]` uses URL APIs incompatible with Node < 18.17. No longer relevant. ### Related - P0 issue: aws/aws-cdk#37870 - Rico's bundled-dep strip fix: aws/aws-cdk#37726 - Momo's cloud-assembly-api bump (introduced the conflict): aws/aws-cdk#37774 - Original Node compat pin: aws#61 --- By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license --------- Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It looks like
jsonschema 1.5.0contains changes that are not compatible with Node versions below 18.17. Hold back the version to 1.4.1.Relates to aws/aws-cdk#33495
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license