Skip to content

fix(cloud-assembly-schema/cli): manifest validation fails on Node <18.17#61

Merged
rix0rrr merged 2 commits into
mainfrom
huijbers/hold-back-jsonschema
Feb 19, 2025
Merged

fix(cloud-assembly-schema/cli): manifest validation fails on Node <18.17#61
rix0rrr merged 2 commits into
mainfrom
huijbers/hold-back-jsonschema

Conversation

@rix0rrr

@rix0rrr rix0rrr commented Feb 18, 2025

Copy link
Copy Markdown
Contributor

It looks like jsonschema 1.5.0 contains changes that are not compatible with Node versions below 18.17. Hold back the version to 1.4.1.

Relates to aws/aws-cdk#33495


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

It looks like `jsonschema 1.5.0` contains changes that are not
compatible with Node 16. Hold back the version to 1.4.1.
@rix0rrr
rix0rrr requested a review from a team February 18, 2025 23:57
Signed-off-by: github-actions <[email protected]>
@rix0rrr rix0rrr changed the title fix(cloud-assembly-schema/cli): manifest validation fails on Node 16 fix(cloud-assembly-schema/cli): manifest validation fails on Node <18.17 Feb 19, 2025
@rix0rrr
rix0rrr disabled auto-merge February 19, 2025 00:23
@rix0rrr
rix0rrr merged commit bc82193 into main Feb 19, 2025
@rix0rrr
rix0rrr deleted the huijbers/hold-back-jsonschema branch February 19, 2025 00:23
mrgrain pushed a commit to go-to-k/aws-cdk-cli that referenced this pull request Jun 22, 2026
…11 (aws#1529)

## P0 Fix: npm ci fails on npm 11 with [email protected]

Fixes aws/aws-cdk#37870

### Problem

`npm ci` fails on npm 11 with `Missing: [email protected] from lock file`
when using [email protected]. The root cause is that
`@aws-cdk/cloud-assembly-api` declares `jsonschema: "~1.4.1"` in its
dependencies, but aws-cdk-lib bundles `[email protected]` at the top
level. The tilde range `~1.4.1` excludes 1.5.0, so npm 11's stricter
lock file validation rejects the mismatch.

### Fix

Widen the range from `~1.4.1` to `^1.5.0`. The original tilde pin was
introduced in PR aws#61 to work around `[email protected]` being
incompatible with Node &lt; 18.17. Since CDK has dropped Node 18 support
entirely, this constraint no longer applies.

### Context

- Rico noted in aws/aws-cdk#37717 that
unbundling `cloud-assembly-api` is not viable because it's not a jsii
module. PR #37721 (community attempt at unbundling) confirmed this with
build failures.
- This was identified as the other viable fix option: widen the range at
the source in this repo.
- Original pin reason (PR aws#61): `[email protected]` uses URL APIs
incompatible with Node &lt; 18.17. No longer relevant.

### Related

- P0 issue: aws/aws-cdk#37870
- Rico's bundled-dep strip fix:
aws/aws-cdk#37726
- Momo's cloud-assembly-api bump (introduced the conflict):
aws/aws-cdk#37774
- Original Node compat pin: aws#61

---
By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache-2.0 license

---------

Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants