chore(cli): remove unused legacy deployment options#1269
Merged
aws-cdk-automation merged 1 commit intomainfrom Mar 27, 2026
Merged
Conversation
Remove deprecated `hotswap`, `hotswapPropertyOverrides`, `execute`, `changeSetName`, and `ignoreNoStacks` options from `DeployStackOptions` interfaces. These were legacy compatibility shims that translated old options into the `deploymentMethod` parameter. All callers now use `deploymentMethod` directly. Update tests to use `deploymentMethod` instead of the removed options.
mrgrain
changed the title
mrgrain
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1269 +/- ##
==========================================
- Coverage 88.13% 88.11% -0.03%
==========================================
Files 73 73
Lines 10379 10359 -20
Branches 1410 1410
==========================================
- Hits 9148 9128 -20
Misses 1204 1204
Partials 27 27
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
rix0rrr
approved these changes
Mar 27, 2026
aws-cdk-automation
deleted the
mrgrain/refactor/deployments/remove-legacy-deploy-options
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was made possible by the migration in #1250, which moved all callers to use
deploymentMethoddirectly.The
DeployStackOptionsinterfaces in bothdeploy-stack.tsanddeployments.tsstill carried several deprecated properties that served as legacy compatibility shims, translating old-style options into the newerdeploymentMethodparameter. Since all callers have been migrated to usedeploymentMethoddirectly, these shims are no longer needed and the translation code was dead weight.This removes the deprecated
hotswap,hotswapPropertyOverrides,execute,changeSetName, andignoreNoStacksproperties from the internal deployment interfaces, along with the compatibility translation logic inDeployments.deployStack()anddeployStack(). TheCfnDeployOptionsinterface in the CLI'scdk-toolkit.tsis cleaned up accordingly, no longer passing the removed options through toDeployments.Tests are updated to use
deploymentMethoddirectly instead of the removed options.Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license