Repository navigation
fix(core): skip default validation when context is unresolved - #39560
OKAN-SOFTWARE wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
The pull request linter fails with the following errors:
❌ Fixes must contain a change to an integration test file and the resulting snapshot.
If you believe this pull request should receive an exemption, please comment and provide a justification. A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed, add Clarification Request to a comment.
✅ A exemption request has been requested. Please wait for a maintainer's review.
|
Exemption Request This fix addresses synthesis-time validation behavior when context lookups are unresolved. It does not modify generated CloudFormation resources or deployment behavior. The change is covered by a focused regression test in Validation completed successfully:
Since integration-test snapshots would not directly exercise this synthesis-time validation behavior, I would appreciate an exemption from the integration-test snapshot requirement for this change. |
|
Tick the box to add this pull request to the merge queue (same as
|
Issue # (if applicable)
Closes #38989.
Reason for this change
The built-in CloudFormation validation plugin reports false-positive violations during synthesis when context lookups have not yet resolved. CDK generates temporary placeholder values such as
vpc-12345,p-12345, anddummy-value-for-..., which fail CloudFormation's resource identifier format checks.These warnings can appear during unit tests and initial synthesis, even though the placeholder values are not intended for deployment.
Description of changes
This addresses the false positives centrally without modifying the existing lookup placeholders.
Describe any new or updated permissions being added
None.
Description of how you validated changes
cloudformation-validate-plugin.test.ts.aws-cdk-liband its dependencies: 10 build projects passed.Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.