Repository navigation
Commit d69c51a
authored
fix(route53):
Updates the `CrossAccountZoneDelegationRecord` construct to use sdk v3 / node 18.
This is identical to changes in #26212, except for hardcoding a region into the `assumeRole` sdk call. This may not be the ideal solution, but should not break specific configurations.
That specific configuration, as #26593 pointed out, was that the original update was a breaking change if the construct was deployed into an opt-in region, and the parent zone did not have that opt-in region enabled.
This PR removes the semi-hidden `@aws-cdk/aws-route53:useRegionalStsEndpoint` feature flag, as it was based on a confusion on why things used to work. We now pick the correct endpoint manually.
Closes #26976.
----
*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*CrossAccountZoneDelegationRecord is still using Node 16 (#26980)1 parent f6a5900 commit d69c51a
19 files changed
Lines changed: 1142 additions & 1031 deletions
File tree
- packages
- @aws-cdk-testing/framework-integ/test/aws-route53/test
- integ.cross-account-zone-delegation.js.snapshot
- asset.79d89314ddbd33f89269ebfdd0cab9c219b5f5d59c210d4847fd849b9c341563
- asset.ab0afc2f801b8ac11473bad4d9f22578919d8959b5f1bcd21b05c4ac895dbcab
- aws-cdk-lib/aws-route53
- lib
- cross-account-zone-delegation-handler
- test
- cross-account-zone-delegation-handler
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
0 commit comments