Repository navigation
Commit 99041b2
authored
fix(custom-resources): cannot set logging for state machine generated in CompleteHandler (#28706)
This PR fixes the case that `StateMachine` generated for `CompleteHandler` in `Provider` cannot set logging.
The default log group name of the state machine automatically created by the `Provider` with `isCompleteHandler` should start with `/aws/vendedlogs/states`. Otherwise, each time the state machine is created, the log resource policy size increases.
https://docs.aws.amazon.com/step-functions/latest/dg/bp-cwl.html
Closes #27283
Fixes #28577 #28744
Related PR #27310(reverted by #28699), #28587
----
*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*1 parent 2126ee5 commit 99041b2
143 files changed
Lines changed: 12993 additions & 6062 deletions
File tree
- packages
- @aws-cdk-testing/framework-integ/test
- aws-dynamodb/test
- integ.global-replicas-provisioned.js.snapshot
- integ.global.js.snapshot
- aws-eks/test
- integ.alb-controller.js.snapshot
- integ.eks-al2023-nodegroup.js.snapshot
- asset.71aae489e8a9171b4e9c4ed9b264e3dad2dd3abfa40efb57071906931624ca52
- integ.eks-bottlerocket-ng.js.snapshot
- integ.eks-cluster-handlers-vpc.js.snapshot
- integ.eks-cluster-imported.js.snapshot
- integ.eks-cluster-ipv6.js.snapshot
- integ.eks-cluster-private-endpoint.js.snapshot
- integ.eks-cluster.js.snapshot
- asset.1471fa6f2876749a13de79989efc6651c9768d3173ef5904947e87504f8d7069
- apply
- get
- helm
- patch
- asset.1b5aaa158e02216aa983cbf998d740faf1176f70b3769f77295e9bd20f543edf
- integ.eks-helm-asset.js.snapshot
- integ.eks-inference-nodegroup.js.snapshot
- integ.eks-inference.js.snapshot
- integ.eks-service-account-sdk-call.js.snapshot
- asset.0e38a6f1038236070a71ea121254b10165afd106e97d2a6dc7201c14c947c115
- asset.9b9f13274813029a1d48bc83e739e288b3d978b750b42928b862c9f007b75d47
- integ.eks-windows-ng.js.snapshot
- integ.fargate-cluster.js.snapshot
- sdk-call-integ-test-docker-app/app
- aws-rds/test/integ.cluster-snapshot.js.snapshot
- aws-stepfunctions-tasks/test
- eks/integ.call.js.snapshot
- emrcontainers
- integ.job-submission-workflow.js.snapshot
- integ.start-job-run.js.snapshot
- custom-resources/test/provider-framework
- integ.provider-with-waiter-state-machine.js.snapshot
- asset.15197a5512179542fe2cff74af89bb047793c9c4e0b4395f114641a81cd52ae5
- asset.4554b47be6f57b68c6c7a7391dcc73894866d2377fe174883351e7639097f292
- asset.c014eecccbb25b3f9b2930f62990f5a373bb117a6c78807df15d78a5ac33e9cd
- asset.e978ad4ad0dca7e1c6be5f49cbbd1c5a150ee050c24052fedfe5a42f835d55da
- integ.provider.js.snapshot
- @aws-cdk/aws-amplify-alpha/test/integ.app-asset-deployment.js.snapshot
- aws-cdk-lib/custom-resources
- lib/provider-framework
- test/provider-framework
Some content is hidden
Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
291 | 291 | | |
292 | 292 | | |
293 | 293 | | |
294 | | - | |
| 294 | + | |
295 | 295 | | |
296 | 296 | | |
297 | 297 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
676 | 676 | | |
677 | 677 | | |
678 | 678 | | |
| 679 | + | |
| 680 | + | |
| 681 | + | |
| 682 | + | |
| 683 | + | |
| 684 | + | |
| 685 | + | |
| 686 | + | |
| 687 | + | |
| 688 | + | |
| 689 | + | |
| 690 | + | |
| 691 | + | |
| 692 | + | |
| 693 | + | |
| 694 | + | |
679 | 695 | | |
680 | 696 | | |
681 | 697 | | |
| |||
688 | 704 | | |
689 | 705 | | |
690 | 706 | | |
| 707 | + | |
| 708 | + | |
| 709 | + | |
| 710 | + | |
| 711 | + | |
| 712 | + | |
| 713 | + | |
| 714 | + | |
| 715 | + | |
| 716 | + | |
| 717 | + | |
| 718 | + | |
| 719 | + | |
| 720 | + | |
| 721 | + | |
| 722 | + | |
| 723 | + | |
| 724 | + | |
| 725 | + | |
| 726 | + | |
691 | 727 | | |
692 | 728 | | |
693 | 729 | | |
| |||
713 | 749 | | |
714 | 750 | | |
715 | 751 | | |
| 752 | + | |
| 753 | + | |
| 754 | + | |
| 755 | + | |
| 756 | + | |
| 757 | + | |
| 758 | + | |
| 759 | + | |
| 760 | + | |
| 761 | + | |
| 762 | + | |
| 763 | + | |
| 764 | + | |
| 765 | + | |
| 766 | + | |
| 767 | + | |
716 | 768 | | |
717 | 769 | | |
718 | 770 | | |
| |||
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
246 | 246 | | |
247 | 247 | | |
248 | 248 | | |
249 | | - | |
| 249 | + | |
250 | 250 | | |
251 | 251 | | |
252 | 252 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
672 | 672 | | |
673 | 673 | | |
674 | 674 | | |
| 675 | + | |
| 676 | + | |
| 677 | + | |
| 678 | + | |
| 679 | + | |
| 680 | + | |
| 681 | + | |
| 682 | + | |
| 683 | + | |
| 684 | + | |
| 685 | + | |
| 686 | + | |
| 687 | + | |
| 688 | + | |
| 689 | + | |
| 690 | + | |
675 | 691 | | |
676 | 692 | | |
677 | 693 | | |
| |||
684 | 700 | | |
685 | 701 | | |
686 | 702 | | |
| 703 | + | |
| 704 | + | |
| 705 | + | |
| 706 | + | |
| 707 | + | |
| 708 | + | |
| 709 | + | |
| 710 | + | |
| 711 | + | |
| 712 | + | |
| 713 | + | |
| 714 | + | |
| 715 | + | |
| 716 | + | |
| 717 | + | |
| 718 | + | |
| 719 | + | |
| 720 | + | |
| 721 | + | |
| 722 | + | |
687 | 723 | | |
688 | 724 | | |
689 | 725 | | |
| |||
709 | 745 | | |
710 | 746 | | |
711 | 747 | | |
| 748 | + | |
| 749 | + | |
| 750 | + | |
| 751 | + | |
| 752 | + | |
| 753 | + | |
| 754 | + | |
| 755 | + | |
| 756 | + | |
| 757 | + | |
| 758 | + | |
| 759 | + | |
| 760 | + | |
| 761 | + | |
| 762 | + | |
| 763 | + | |
712 | 764 | | |
713 | 765 | | |
714 | 766 | | |
| |||
0 commit comments