Repository navigation
Commit 735b786
authored
fix(s3): bucket deletion fails if object creation races against cleanup (#26875)
Adds a DENY policy for S3:PutObject on buckets to be auto-deleted to prevent a race condition on emptying with external bucket writers.
As a new contributor, the requirements for integration testing were unclear to me. I have tested the policy on my own buckets and included unit tests, but am willing to work toward code compliance with assistance.
Closes #26874.
----
*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*1 parent 0c66a20 commit 735b786
303 files changed
Lines changed: 143925 additions & 5187 deletions
File tree
- packages
- @aws-cdk-testing/framework-integ/test
- aws-cloudtrail/test
- integ.cloudtrail-insight.js.snapshot
- asset.2ec8ad9e91dcd6e7ad6a5c84ffc6c9c05c408aca3b26ceb2816d81043e6c4dc3
- asset.3e6ea85c994cf2198f02e67a9e98e8f23456efa8bd72dd55b3a86454c4db9d5f
- integ.cloudtrail-supplied-bucket.lit.js.snapshot
- asset.120f2d9f06d56bd1038e8bb4bc7fa0b1758f62b6c772f4ac166b811e9ed71cf9
- asset.2ec8ad9e91dcd6e7ad6a5c84ffc6c9c05c408aca3b26ceb2816d81043e6c4dc3
- integ.cloudtrail.lit.js.snapshot
- asset.120f2d9f06d56bd1038e8bb4bc7fa0b1758f62b6c772f4ac166b811e9ed71cf9
- asset.2ec8ad9e91dcd6e7ad6a5c84ffc6c9c05c408aca3b26ceb2816d81043e6c4dc3
- aws-codepipeline-actions/test
- cloudformation/integ.stacksets.js.snapshot
- asset.120f2d9f06d56bd1038e8bb4bc7fa0b1758f62b6c772f4ac166b811e9ed71cf9
- asset.2ec8ad9e91dcd6e7ad6a5c84ffc6c9c05c408aca3b26ceb2816d81043e6c4dc3
- integ.pipeline-elastic-beanstalk-deploy.js.snapshot
- integ.pipeline-s3-deploy.js.snapshot
- asset.120f2d9f06d56bd1038e8bb4bc7fa0b1758f62b6c772f4ac166b811e9ed71cf9
- asset.2ec8ad9e91dcd6e7ad6a5c84ffc6c9c05c408aca3b26ceb2816d81043e6c4dc3
- asset.63ae5d5f48d3638501e722718b99b5f2fddb9ab73a15d7cb607215a500df19e1.bundle
- integ.pipeline-with-replication.js.snapshot
- asset.1a067234d252533a95ecaaccd4b3e821e6a69df0b03b918b596fc5a40eeb71a1
- aws-ec2/test
- integ.vpc-flow-logs-customformat.js.snapshot
- asset.120f2d9f06d56bd1038e8bb4bc7fa0b1758f62b6c772f4ac166b811e9ed71cf9
- asset.2ec8ad9e91dcd6e7ad6a5c84ffc6c9c05c408aca3b26ceb2816d81043e6c4dc3
- integ.vpc-flow-logs-interval.js.snapshot
- asset.120f2d9f06d56bd1038e8bb4bc7fa0b1758f62b6c772f4ac166b811e9ed71cf9
- asset.2ec8ad9e91dcd6e7ad6a5c84ffc6c9c05c408aca3b26ceb2816d81043e6c4dc3
- integ.vpc-flow-logs.js.snapshot
- asset.120f2d9f06d56bd1038e8bb4bc7fa0b1758f62b6c772f4ac166b811e9ed71cf9
- asset.2ec8ad9e91dcd6e7ad6a5c84ffc6c9c05c408aca3b26ceb2816d81043e6c4dc3
- asset.63ae5d5f48d3638501e722718b99b5f2fddb9ab73a15d7cb607215a500df19e1.bundle
- aws-ecs/test/ec2/integ.environment-file.js.snapshot
- asset.120f2d9f06d56bd1038e8bb4bc7fa0b1758f62b6c772f4ac166b811e9ed71cf9
- asset.2ec8ad9e91dcd6e7ad6a5c84ffc6c9c05c408aca3b26ceb2816d81043e6c4dc3
- aws-elasticloadbalancingv2/test/integ.alb.log.js.snapshot
- asset.120f2d9f06d56bd1038e8bb4bc7fa0b1758f62b6c772f4ac166b811e9ed71cf9
- asset.2ec8ad9e91dcd6e7ad6a5c84ffc6c9c05c408aca3b26ceb2816d81043e6c4dc3
- aws-lambda-event-sources/test/integ.s3.js.snapshot
- asset.120f2d9f06d56bd1038e8bb4bc7fa0b1758f62b6c772f4ac166b811e9ed71cf9
- asset.2ec8ad9e91dcd6e7ad6a5c84ffc6c9c05c408aca3b26ceb2816d81043e6c4dc3
- aws-s3-deployment/test
- integ.bucket-deployment-cloudfront.js.snapshot
- asset.120f2d9f06d56bd1038e8bb4bc7fa0b1758f62b6c772f4ac166b811e9ed71cf9
- asset.2ec8ad9e91dcd6e7ad6a5c84ffc6c9c05c408aca3b26ceb2816d81043e6c4dc3
- integ.bucket-deployment-deployed-bucket.js.snapshot
- asset.120f2d9f06d56bd1038e8bb4bc7fa0b1758f62b6c772f4ac166b811e9ed71cf9
- asset.2ec8ad9e91dcd6e7ad6a5c84ffc6c9c05c408aca3b26ceb2816d81043e6c4dc3
- integ.bucket-deployment-signcontent.js.snapshot
- asset.120f2d9f06d56bd1038e8bb4bc7fa0b1758f62b6c772f4ac166b811e9ed71cf9
- asset.2ec8ad9e91dcd6e7ad6a5c84ffc6c9c05c408aca3b26ceb2816d81043e6c4dc3
- integ.bucket-deployment.js.snapshot
- asset.120f2d9f06d56bd1038e8bb4bc7fa0b1758f62b6c772f4ac166b811e9ed71cf9
- asset.2ec8ad9e91dcd6e7ad6a5c84ffc6c9c05c408aca3b26ceb2816d81043e6c4dc3
- asset.63ae5d5f48d3638501e722718b99b5f2fddb9ab73a15d7cb607215a500df19e1.bundle
- aws-s3-notifications/test/sqs/integ.bucket-notifications.js.snapshot
- asset.120f2d9f06d56bd1038e8bb4bc7fa0b1758f62b6c772f4ac166b811e9ed71cf9
- asset.2ec8ad9e91dcd6e7ad6a5c84ffc6c9c05c408aca3b26ceb2816d81043e6c4dc3
- asset.63ae5d5f48d3638501e722718b99b5f2fddb9ab73a15d7cb607215a500df19e1.bundle
- aws-s3/test
- integ.bucket-auto-delete-objects.js.snapshot
- asset.120f2d9f06d56bd1038e8bb4bc7fa0b1758f62b6c772f4ac166b811e9ed71cf9
- asset.2ec8ad9e91dcd6e7ad6a5c84ffc6c9c05c408aca3b26ceb2816d81043e6c4dc3
- integ.bucket-import-server-access-logs.js.snapshot
- asset.120f2d9f06d56bd1038e8bb4bc7fa0b1758f62b6c772f4ac166b811e9ed71cf9
- asset.2ec8ad9e91dcd6e7ad6a5c84ffc6c9c05c408aca3b26ceb2816d81043e6c4dc3
- integ.bucket-server-access-logs-sse-kms.js.snapshot
- asset.120f2d9f06d56bd1038e8bb4bc7fa0b1758f62b6c772f4ac166b811e9ed71cf9
- asset.2ec8ad9e91dcd6e7ad6a5c84ffc6c9c05c408aca3b26ceb2816d81043e6c4dc3
- aws-servicecatalog/test
- integ.product.encrypted.asset.js.snapshot
- asset.216218e507a977a1bb3592f29c1a62ab3e0a9eb25569109a395315638e154329
- asset.2ec8ad9e91dcd6e7ad6a5c84ffc6c9c05c408aca3b26ceb2816d81043e6c4dc3
- integ.product.js.snapshot
- integ.two-products.js.snapshot
- aws-synthetics/test/integ.canary.js.snapshot
- asset.216218e507a977a1bb3592f29c1a62ab3e0a9eb25569109a395315638e154329
- pipelines/test
- integ.newpipeline-with-file-system-locations.js.snapshot
- assembly-PipelinesFileSystemLocations-Beta
- asset.120f2d9f06d56bd1038e8bb4bc7fa0b1758f62b6c772f4ac166b811e9ed71cf9
- asset.2ec8ad9e91dcd6e7ad6a5c84ffc6c9c05c408aca3b26ceb2816d81043e6c4dc3
- integ.pipeline-security.js.snapshot
- assembly-PipelineSecurityStack-DisableSecurityCheck
- assembly-PipelineSecurityStack-EnableSecurityCheck
- assembly-PipelineSecurityStack-NoSecurityCheck
- assembly-PipelineSecurityStack-PreProduction
- assembly-PipelineSecurityStack-SafeProduction
- assembly-PipelineSecurityStack-SingleStage
- asset.120f2d9f06d56bd1038e8bb4bc7fa0b1758f62b6c772f4ac166b811e9ed71cf9
- asset.2ec8ad9e91dcd6e7ad6a5c84ffc6c9c05c408aca3b26ceb2816d81043e6c4dc3
- integ.pipeline-with-assets-single-upload.js.snapshot
- assembly-PipelineStack-PreProd
- asset.120f2d9f06d56bd1038e8bb4bc7fa0b1758f62b6c772f4ac166b811e9ed71cf9
- asset.2ec8ad9e91dcd6e7ad6a5c84ffc6c9c05c408aca3b26ceb2816d81043e6c4dc3
- integ.pipeline-with-assets.js.snapshot
- assembly-PipelineStack-PreProd
- asset.120f2d9f06d56bd1038e8bb4bc7fa0b1758f62b6c772f4ac166b811e9ed71cf9
- asset.2ec8ad9e91dcd6e7ad6a5c84ffc6c9c05c408aca3b26ceb2816d81043e6c4dc3
- integ.pipeline-with-variables.js.snapshot
- asset.120f2d9f06d56bd1038e8bb4bc7fa0b1758f62b6c772f4ac166b811e9ed71cf9
- asset.2ec8ad9e91dcd6e7ad6a5c84ffc6c9c05c408aca3b26ceb2816d81043e6c4dc3
- integ.pipeline-without-prepare.js.snapshot
- assembly-PreparelessPipelineStack-MyStage
- assembly-PreparelessPipelineStack-MyStage-Stack-MyApp
- asset.120f2d9f06d56bd1038e8bb4bc7fa0b1758f62b6c772f4ac166b811e9ed71cf9
- asset.2ec8ad9e91dcd6e7ad6a5c84ffc6c9c05c408aca3b26ceb2816d81043e6c4dc3
- integ.pipeline.js.snapshot
- assembly-PipelineStack-PreProd
- asset.120f2d9f06d56bd1038e8bb4bc7fa0b1758f62b6c772f4ac166b811e9ed71cf9
- asset.2ec8ad9e91dcd6e7ad6a5c84ffc6c9c05c408aca3b26ceb2816d81043e6c4dc3
- @aws-cdk
- app-staging-synthesizer-alpha/test
- integ.synth-default-resources.js.snapshot
- integ.synth-default-resources.ts.snapshot
- asset.16624c2a162b07c5cc0e2c59c484f638bac238ca558ccbdc2aa0e0535df3e622
- asset.68539effc3f7ad46fff9765606c2a01b7f7965833643ab37e62799f19a37f650
- aws-kinesisfirehose-destinations-alpha/test/integ.s3-bucket.lit.js.snapshot
- asset.216218e507a977a1bb3592f29c1a62ab3e0a9eb25569109a395315638e154329
- asset.2ec8ad9e91dcd6e7ad6a5c84ffc6c9c05c408aca3b26ceb2816d81043e6c4dc3
- aws-msk-alpha/test
- integ.add-cluster-user.ts.snapshot
- asset.63ae5d5f48d3638501e722718b99b5f2fddb9ab73a15d7cb607215a500df19e1.bundle
- asset.e5178afc49b7c6a85127a67856ce958e4f0879ce6aad5e974cac2a088bf939db
- integ.cluster-version.ts.snapshot
- integ.cluster-zookeeper.ts.snapshot
- asset.e5178afc49b7c6a85127a67856ce958e4f0879ce6aad5e974cac2a088bf939db
- integ.cluster.js.snapshot
- asset.120f2d9f06d56bd1038e8bb4bc7fa0b1758f62b6c772f4ac166b811e9ed71cf9
- asset.2ec8ad9e91dcd6e7ad6a5c84ffc6c9c05c408aca3b26ceb2816d81043e6c4dc3
- asset.63ae5d5f48d3638501e722718b99b5f2fddb9ab73a15d7cb607215a500df19e1.bundle
- integ.cluster.ts.snapshot
- asset.1f3c2cfb18e102edc713fe4c4b4d87572f4297ee4a5e80a5960adf526ee9ea28.bundle
- asset.2ec8ad9e91dcd6e7ad6a5c84ffc6c9c05c408aca3b26ceb2816d81043e6c4dc3
- asset.33e2651435a0d472a75c1e033c9832b21321d9e56711926b04c5705e5f63874c
- asset.63ae5d5f48d3638501e722718b99b5f2fddb9ab73a15d7cb607215a500df19e1.bundle
- asset.a268caa53756f51bda8ad5f499be4ed8484a81b314811806fbb66f874837c476
- asset.e5178afc49b7c6a85127a67856ce958e4f0879ce6aad5e974cac2a088bf939db
- aws-synthetics-alpha/test/integ.canary.js.snapshot
- asset.086fe534b1e7545fbc662251685b8a7d91ab2061bbfe98d857b27478442487cb
- asset.2ec8ad9e91dcd6e7ad6a5c84ffc6c9c05c408aca3b26ceb2816d81043e6c4dc3
- asset.63ae5d5f48d3638501e722718b99b5f2fddb9ab73a15d7cb607215a500df19e1.bundle
- custom-resource-handlers
- lib/aws-s3/auto-delete-objects-handler
- test/aws-s3
- aws-cdk-lib/aws-s3
- lib
- test
Some content is hidden
Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
25 | 25 | | |
26 | 26 | | |
27 | 27 | | |
28 | | - | |
| 28 | + | |
| 29 | + | |
29 | 30 | | |
30 | 31 | | |
31 | 32 | | |
| |||
155 | 156 | | |
156 | 157 | | |
157 | 158 | | |
158 | | - | |
| 159 | + | |
159 | 160 | | |
160 | 161 | | |
161 | 162 | | |
| |||
187 | 188 | | |
188 | 189 | | |
189 | 190 | | |
190 | | - | |
191 | | - | |
192 | | - | |
193 | | - | |
194 | 191 | | |
195 | 192 | | |
196 | 193 | | |
| |||
202 | 199 | | |
203 | 200 | | |
204 | 201 | | |
205 | | - | |
| 202 | + | |
| 203 | + | |
| 204 | + | |
| 205 | + | |
| 206 | + | |
206 | 207 | | |
207 | 208 | | |
208 | 209 | | |
| |||
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
0 commit comments