Repository navigation
Commit 2da544f
authored
fix(ses-actions): permissions too wide for S3 action (#29833)
### Issue # (if applicable)
Closes #29811, continuation of @msambol 's #29823
### Reason for this change
Reduce overly broad permissions allocated to SES for the S3 receipt rule action
### Description of changes
* Restrain by both rule set and rule name, as recommended in the [docs](https://docs.aws.amazon.com/ses/latest/dg/receiving-email-permissions.html#receiving-email-permissions-s3)
* Accomplished by generating the permission lazily, when the rule is rendering the actions for CloudFormation
### Description of how you validated changes
Updated the unit and integration tests. The integration now uses a free test WorkMail domain. It's a bit of manual setup upfront, but doesn't require the contributor to use one of their own domains
### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)
----
*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*1 parent 9eb21bd commit 2da544f
14 files changed
Lines changed: 325 additions & 401 deletions
File tree
- packages
- @aws-cdk-testing/framework-integ/test/aws-ses-actions/test
- integ.actions.js.snapshot
- asset.96d0b6be9a64ae309bf89a86f5515453f0fa1d07b4f6b37198051cc98e251f34
- aws-cdk-lib
- aws-ses-actions
- lib
- test
- aws-ses/lib
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
86 | 86 | | |
87 | 87 | | |
88 | 88 | | |
89 | | - | |
| 89 | + | |
90 | 90 | | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
91 | 114 | | |
92 | 115 | | |
93 | 116 | | |
| |||
172 | 195 | | |
173 | 196 | | |
174 | 197 | | |
175 | | - | |
176 | | - | |
177 | | - | |
178 | | - | |
179 | | - | |
180 | | - | |
181 | | - | |
182 | | - | |
183 | | - | |
184 | | - | |
185 | | - | |
186 | | - | |
187 | | - | |
188 | | - | |
189 | | - | |
190 | | - | |
191 | | - | |
192 | | - | |
193 | | - | |
194 | | - | |
195 | | - | |
196 | | - | |
197 | | - | |
198 | | - | |
199 | | - | |
200 | | - | |
201 | | - | |
202 | | - | |
203 | 198 | | |
204 | 199 | | |
205 | 200 | | |
206 | | - | |
207 | | - | |
208 | | - | |
209 | 201 | | |
210 | 202 | | |
211 | 203 | | |
| |||
256 | 248 | | |
257 | 249 | | |
258 | 250 | | |
259 | | - | |
| 251 | + | |
260 | 252 | | |
261 | 253 | | |
262 | 254 | | |
| |||
268 | 260 | | |
269 | 261 | | |
270 | 262 | | |
271 | | - | |
| 263 | + | |
272 | 264 | | |
273 | 265 | | |
274 | 266 | | |
275 | 267 | | |
276 | | - | |
277 | | - | |
278 | | - | |
| 268 | + | |
279 | 269 | | |
280 | 270 | | |
281 | | - | |
282 | 271 | | |
283 | 272 | | |
284 | 273 | | |
| |||
301 | 290 | | |
302 | 291 | | |
303 | 292 | | |
304 | | - | |
305 | | - | |
306 | | - | |
| 293 | + | |
307 | 294 | | |
308 | 295 | | |
309 | | - | |
310 | | - | |
| 296 | + | |
| 297 | + | |
| 298 | + | |
| 299 | + | |
| 300 | + | |
| 301 | + | |
| 302 | + | |
311 | 303 | | |
312 | | - | |
| 304 | + | |
313 | 305 | | |
314 | 306 | | |
315 | | - | |
| 307 | + | |
| 308 | + | |
| 309 | + | |
| 310 | + | |
| 311 | + | |
| 312 | + | |
| 313 | + | |
| 314 | + | |
316 | 315 | | |
317 | 316 | | |
318 | | - | |
| 317 | + | |
| 318 | + | |
| 319 | + | |
| 320 | + | |
| 321 | + | |
| 322 | + | |
| 323 | + | |
319 | 324 | | |
320 | 325 | | |
321 | 326 | | |
322 | 327 | | |
323 | 328 | | |
324 | | - | |
| 329 | + | |
325 | 330 | | |
326 | | - | |
327 | | - | |
328 | | - | |
329 | | - | |
330 | | - | |
331 | | - | |
332 | | - | |
333 | | - | |
334 | | - | |
335 | | - | |
| 331 | + | |
336 | 332 | | |
337 | 333 | | |
338 | 334 | | |
339 | 335 | | |
340 | | - | |
341 | | - | |
| 336 | + | |
| 337 | + | |
342 | 338 | | |
343 | | - | |
344 | | - | |
345 | | - | |
346 | | - | |
347 | | - | |
348 | | - | |
349 | | - | |
350 | | - | |
| 339 | + | |
351 | 340 | | |
352 | | - | |
| 341 | + | |
353 | 342 | | |
354 | 343 | | |
355 | 344 | | |
356 | | - | |
| 345 | + | |
| 346 | + | |
| 347 | + | |
| 348 | + | |
357 | 349 | | |
358 | 350 | | |
359 | | - | |
| 351 | + | |
360 | 352 | | |
361 | | - | |
362 | | - | |
363 | | - | |
364 | | - | |
365 | | - | |
366 | | - | |
367 | | - | |
368 | | - | |
369 | | - | |
370 | | - | |
371 | | - | |
372 | | - | |
373 | | - | |
374 | | - | |
375 | | - | |
376 | | - | |
377 | 353 | | |
378 | 354 | | |
379 | 355 | | |
| |||
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
0 commit comments