Repository navigation
Commit 1fd22a7
authored
fix(rds): prevent rendering deprecated credentials when creating a database cluster from a snapshot (under feature flag) (#27174)
This PR fixes a bug where an extra database secret is being generated when an RDS database cluster is being created from a snapshot.
On the `DatabaseClusterFromSnapshotProps` interface, we deprecated the `credentials` property and, at the same, introduced `snapshotCredentials` as the recommended replacement. However, the default behavior associated with the `credentials` property was not removed as doing so would introduce a breaking change for some users as detailed in this [PR](#20777). As a result, users just using the recommended `snapshotCredentials` property to create a new RDS database cluster are seeing an extra, unwanted secret being created.
Closes #23815
----
*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*1 parent 3d9ca8d commit 1fd22a7
10 files changed
Lines changed: 180 additions & 163 deletions
File tree
- packages
- @aws-cdk-testing/framework-integ/test/aws-rds/test
- integ.cluster-snapshot.js.snapshot
- aws-cdk-lib
- aws-rds
- lib
- private
- test
- cx-api
- lib
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
426 | 426 | | |
427 | 427 | | |
428 | 428 | | |
429 | | - | |
| 429 | + | |
430 | 430 | | |
431 | 431 | | |
432 | 432 | | |
433 | 433 | | |
434 | | - | |
| 434 | + | |
435 | 435 | | |
436 | 436 | | |
437 | 437 | | |
| |||
474 | 474 | | |
475 | 475 | | |
476 | 476 | | |
477 | | - | |
| 477 | + | |
478 | 478 | | |
479 | 479 | | |
480 | 480 | | |
| |||
495 | 495 | | |
496 | 496 | | |
497 | 497 | | |
498 | | - | |
| 498 | + | |
499 | 499 | | |
500 | 500 | | |
501 | 501 | | |
| |||
1357 | 1357 | | |
1358 | 1358 | | |
1359 | 1359 | | |
1360 | | - | |
1361 | | - | |
1362 | | - | |
1363 | | - | |
1364 | | - | |
1365 | | - | |
1366 | | - | |
1367 | | - | |
1368 | | - | |
1369 | | - | |
1370 | | - | |
1371 | | - | |
1372 | | - | |
1373 | | - | |
1374 | | - | |
1375 | | - | |
1376 | | - | |
1377 | | - | |
1378 | | - | |
1379 | | - | |
1380 | | - | |
1381 | | - | |
1382 | | - | |
1383 | | - | |
1384 | | - | |
1385 | | - | |
1386 | | - | |
1387 | | - | |
1388 | | - | |
1389 | | - | |
1390 | | - | |
1391 | | - | |
1392 | | - | |
1393 | | - | |
1394 | | - | |
1395 | | - | |
1396 | 1360 | | |
1397 | 1361 | | |
1398 | 1362 | | |
| |||
1486 | 1450 | | |
1487 | 1451 | | |
1488 | 1452 | | |
1489 | | - | |
| 1453 | + | |
1490 | 1454 | | |
1491 | 1455 | | |
1492 | 1456 | | |
1493 | 1457 | | |
1494 | | - | |
| 1458 | + | |
1495 | 1459 | | |
1496 | 1460 | | |
1497 | 1461 | | |
| |||
1528 | 1492 | | |
1529 | 1493 | | |
1530 | 1494 | | |
1531 | | - | |
| 1495 | + | |
1532 | 1496 | | |
1533 | 1497 | | |
1534 | 1498 | | |
| |||
1549 | 1513 | | |
1550 | 1514 | | |
1551 | 1515 | | |
1552 | | - | |
| 1516 | + | |
1553 | 1517 | | |
1554 | 1518 | | |
1555 | 1519 | | |
| |||
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
17 | 17 | | |
18 | 18 | | |
19 | 19 | | |
20 | | - | |
| 20 | + | |
21 | 21 | | |
22 | 22 | | |
23 | 23 | | |
24 | | - | |
| 24 | + | |
25 | 25 | | |
26 | 26 | | |
27 | 27 | | |
| |||
42 | 42 | | |
43 | 43 | | |
44 | 44 | | |
45 | | - | |
| 45 | + | |
46 | 46 | | |
47 | 47 | | |
48 | 48 | | |
| |||
0 commit comments