Conversation
|
|
||
| class DriverInfo: | ||
| DRIVER_NAME = "Amazon Web Services (AWS) Advanced Python Wrapper" | ||
| DRIVER_VERSION = toml.load("pyproject.toml")["tool"]["poetry"]["version"] |
There was a problem hiding this comment.
Previously, this would try to load pyproject.toml at the current working directory. So running pytest from the project root worked but running it from inside tests/unit did not
| ] | ||
|
|
||
| [tool.poetry.dependencies] | ||
| python = "^3.8.1" |
There was a problem hiding this comment.
Is there a reason this is ^3.8.1 instead of ^3.8
There was a problem hiding this comment.
I don't think there was a particular reason
| "Programming Language :: Python :: 3.8", | ||
| "Programming Language :: Python :: 3.9", | ||
| "Programming Language :: Python :: 3.10", | ||
| "Programming Language :: Python :: 3.11", |
There was a problem hiding this comment.
Should I add 3.12 even though we don't test it? I know boto3 supports 3.12
| "Programming Language :: Python :: 3.11", | ||
| ] | ||
|
|
||
| [tool.poetry.dependencies] |
There was a problem hiding this comment.
I wonder if we have our optional/extra dependencies set up correctly for packaging, my main confusion is there are two concepts in poetry: dependency groups and extras. In the poetry docs they use dependency groups to separate out the test dependencies, but they also say extras should be used for optional dependencies that enhance a package but are not required. There's also this SO post but I'm still not sure if dependency groups or extras should be used (or both)
There was a problem hiding this comment.
We can't use both dependency groups and extras at the same time.
I don't think what we are doing right now is wrong, it still works, but I think we can move the target driver dependencies and sqlalchemy to extras for a smoother user experience.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.