Restore compile-time loading of JS files and adapt empty data files #304
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Mirroring internal CR 217619824
Description
std::fs::read_to_string) back to compile-time loading (throughinclude_directory!). This bug caused previously built binary to not able to load the JS files and include them in the report (unless it's running in the build environment where the JS files present)when the
aperf_statsdata are not written to the binary file. A new unit test was added to cover this case.Tests
Built the binary with musl and tested it on another machine. Verified that the report was correctly generated.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.