Added eks-aperf.sh, Dockerfile and README-EKS.md for EKS instructions #286
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DDxPlague
reviewed
Jul 10, 2025
Contributor
DDxPlague
left a comment
DDxPlague
left a comment
There was a problem hiding this comment.
these look good to me. Tested it on my cluster with you and got good results.
DDxPlague
approved these changes
Jul 10, 2025
CristianPrundeanu
requested changes
Jul 10, 2025
| case "$1" in | ||
| --node=*) | ||
| NODE_NAME="${1#*=}" | ||
| shift |
Contributor
There was a problem hiding this comment.
Recommend to factor out the parsing so you have less code and don't have to repeat each argument.
Example:
while [ $# -gt 0 ]; do
dest=""
case "${1%=*}" in
--foo) dest=SET_FOO;;
--bar) dest=SET_BAR;;
*) echo "Unknown parameter: $1"; exit 1;;
esac
if [[ "$1" = *=* ]]; then
let ${dest}="${1#*=}"
else
let ${dest}="$2"
shift
fi
shift
done
| kill $LOGS_PID 2>/dev/null || true | ||
|
|
||
| # Copy files from pod to local directory | ||
| LOCAL_FILE="aperf_report_$(date +%Y%m%d-%H%M%S).tar.gz" |
Contributor
There was a problem hiding this comment.
Should we name the report at generate time instead of here (or even allow the user to define the name), to avoid ending up with multiple reports with the same internal name?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Added Kubernetes support for running APerf on Amazon EKS clusters with three new files:
This enhancement enables collecting performance metrics on EKS nodes without requiring direct SSH access, making it easier to profile applications running in Kubernetes environments.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.