Enable perf_frequency command line option. #279
Conversation
|
|
||
| `--profile` gather profiling data using the 'perf' binary | ||
|
|
||
| `-F, --perf-frequency` frequency for perf profiling in Hz (default 99) |
There was a problem hiding this comment.
what happens if I use this without --profile option? will it error out?
There was a problem hiding this comment.
it will be a no op, doesn't fail.
There was a problem hiding this comment.
ubuntu@ip-172-31-85-220:~/aperf$ ./target/debug/aperf record -F 33
[2025-06-13T18:09:23Z INFO aperf] No run-name given. Using aperf_2025-06-13_18_09_23
[2025-06-13T18:09:23Z INFO aperf::record] Starting Data collection...
[2025-06-13T18:09:23Z INFO aperf::record] Preparing data collectors...
[2025-06-13T18:09:23Z WARN aperf::data::perf_stat] Event multiplexing may result in bad PMU data.
[2025-06-13T18:09:24Z INFO aperf::record] Collecting data...
[2025-06-13T18:09:35Z INFO aperf::record] Data collection complete.
[2025-06-13T18:09:35Z INFO aperf] Data collected in ./aperf_2025-06-13_18_09_23/, archived in ./aperf_2025-06-13_18_09_23.tar.gz
ubuntu@ip-172-31-85-220:~/aperf$ ./target/debug/aperf record --profile -F 33
[2025-06-13T18:09:48Z INFO aperf] No run-name given. Using aperf_2025-06-13_18_09_48
[2025-06-13T18:09:48Z INFO aperf::record] Starting Data collection...
[2025-06-13T18:09:48Z INFO aperf::record] Preparing data collectors...
[2025-06-13T18:09:48Z WARN aperf::data::perf_stat] Event multiplexing may result in bad PMU data.
[2025-06-13T18:09:48Z INFO aperf::record] Collecting data...
[2025-06-13T18:10:00Z INFO aperf::data::flamegraphs] Creating flamegraph...
[2025-06-13T18:10:01Z INFO aperf::record] Data collection complete.
[2025-06-13T18:10:07Z INFO aperf] Data collected in ./aperf_2025-06-13_18_09_48/, archived in ./aperf_2025-06-13_18_09_48.tar.gz
There was a problem hiding this comment.
ok. can we add that in README to make it clear? something like below
-F, --perf-frequency: Sets the frequency for perf profiling in Hz (default 99). Only takes effect when used with --profile, otherwise ignored.
There was a problem hiding this comment.
its a perf profiling param, do we need to mention it has to be used with --profile again?
3 participants
Issue #, if available:
Default 99 mayn't be needed for larger runs so giving an option helps.
Description of changes:
Enable an option to overide default 99
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.