Report: Fix issue with '.' in run names #245
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wash-amzn
approved these changes
Feb 18, 2025
src/data/utils.rs
Outdated
Comment on lines
49
to
53
| let mut file_name = pbuf.file_name().unwrap().to_str().unwrap().to_string(); | ||
| if file_name.ends_with(".tar.gz") { | ||
| file_name = file_name.strip_suffix(".tar.gz").unwrap().to_string(); | ||
| } | ||
| Ok(file_name) |
Contributor
There was a problem hiding this comment.
Can't this delegate to notargz_string_name here?
Contributor
Author
There was a problem hiding this comment.
Yes. Will change it.
Contributor
Author
There was a problem hiding this comment.
Updated to include an integration test. We don't want this to break.
There is a bug in the report generation if the user collected record data with a run name containing '.'. In such cases, the report generator, since it was using file_stem(), would incorrectly create the report directory and tarball with different names. To prevent this, use file_name() and a check to remove '.tar.gz' suffix. Also, move to using file_name() instead of file_stem() wherever needed. Add an integration test to check with a run name containing a '.'.
wash-amzn
approved these changes
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a bug in the report generation if the user collected record data with a run name containing
.. In such cases, the report generator, since it was using file_stem(), would incorrectly create the report directory and tarball with different names.To prevent this, use file_name() and a check to remove '.tar.gz' suffix. Also, move to using file_name() instead of file_stem() wherever needed.
2dots.in.name.tar.gz
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.