Skip to content

Conversation

@janaknat
Copy link
Contributor

@janaknat janaknat commented Feb 4, 2025

Update the README with the documentation for the custom-pmu subtool. Also update aperf record with the new --pmu-config flag.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@janaknat janaknat requested a review from a team as a code owner February 4, 2025 16:52
# APerf
## What is APerf?
A CLI tool to gather many pieces of performance data in one go. APerf includes a recorder and a reporter sub tool. The recorder gathers performance metrics, stores them in a set of local files that can then be analyzed via the reporter sub tool.
A CLI tool to gather many pieces of performance data in one go. APerf includes a recorder, reporter and custom-pmu sub tools. The recorder gathers performance metrics, stores them in a set of local files that can then be analyzed via the reporter sub tool. The custom-pmu sub-tool can be used to create custom PMU configs which can configure the events an aperf recorder collects.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/a recorder/recorder/

Comment on lines +77 to +82
**aperf custom-pmu**
1. Download the `aperf` binary.
2. Start `aperf custom-pmu`:
```
./aperf custom-pmu
```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't provide much information IMO


`-p, --pmu-file` Name of the file for the custom PMU configuration

`--verify` Verify the supplied PMU file
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe be a little more specific here: "Verify the supplied PMU file can be parsed. Availability or functionality of the counters are not verified"

@janaknat janaknat merged commit 6ca41ac into aws:main Feb 17, 2025
6 checks passed
@janaknat janaknat deleted the pmudoc branch February 27, 2025 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants