test_get_named_events: Don't try and maintain the set of all possible perf stat keys here. #158
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… perf stat keys here. There are many of them spread across multiple files. Instead, only assert that an expected-in-all-cases (I used 'ipc') key is present.
janaknat
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I ran the tests on a codebuild github runner (I don't actually know the instance type because they don't let you choose), this test was failing. I modified it to dump the event keys, and the failure was because
data-st-tlb-mpkianddata-st-tlb-tw-pkiwere being returned, but hadn't been added to this test's allow-list.The values that the test failure saw
and failed with
Instead of trying to maintain a superset of all possible keys in the test, now it just asserts for a simple case (
ipc) and doesn't try to defend against 'unexpected' ones.This now passes on those codebuild github runners.