Record: Handle Kernel config not available #102
Conversation
| _ => match os_error.raw_os_error().unwrap() { | ||
| libc::EMFILE => error!( | ||
| "Too many open files. Increase limit with `ulimit -n`" | ||
| libc::EMFILE => warn!( |
There was a problem hiding this comment.
Wouldn't this be needed for any basic collection to work in APerf? So, this has to be an error and not warning?
There was a problem hiding this comment.
It doesn't prevent APerf from running.
| use chrono::prelude::*; | ||
| use ctor::ctor; | ||
| use log::{error, trace}; | ||
| use log::{trace, warn}; |
There was a problem hiding this comment.
In general, can we summarize what all are not collected (for which warnings are issued) when requirements are not met and a message is dumped to console or a file/ log?
RamaMalladiGH
left a comment
RamaMalladiGH
left a comment
There was a problem hiding this comment.
Warnings can be summarized to the user on the console or a log file?
src/data/systeminfo.rs
Outdated
| Ok(s) => self.set_instance_metadata(s), | ||
| Err(e) => error!("An error occurred: {}", e), | ||
| Err(e) => { | ||
| warn!("An error occurred: {}", e); |
There was a problem hiding this comment.
What is it, a warning or an error? :p
"Unable to get instance metadata: {}" would be more meaningful since there isn't going to be much context to understand what was being attempted when the failure is reported.
Also, * use WARN in Perf Stat when asking to change system settings. * use WARN in SystemInfo when IMDS fails.
3 participants
Also,
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.