Skip to content

Commit 0d1add1

Browse files
committed
fix(ci): run Node tests without --test-force-exit
--test-force-exit can drop finished tests from the report and still exit 0 (nodejs/node#64833, open; its fix PRs nodejs/node#64857 and #64875 are unmerged). On Node 26.12 and 24.21, runs of the 2088-test suite with the flag reported 2046 to 2088 tests, 6 of 8 runs short; without it, 8 of 8 reported 2088 in the same time. Every test file now exits on its own (91 files, each run alone without the flag), and the 300 s watchdog still bounds a leaked handle.
1 parent a0038f2 commit 0d1add1

2 files changed

Lines changed: 7 additions & 4 deletions

File tree

‎CHANGELOG.md‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -326,6 +326,11 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/).
326326
its own list. The GNOME dictation and package permission tests keep their
327327
scratch under `TMPDIR` too, and the shared app-server tests bind their
328328
sockets inside the `try` that removes them.
329+
- `scripts/ci/run-node-checks.sh` reports every Node test again. It ran
330+
`node --test` with `--test-force-exit`, which can drop finished tests from
331+
the report and still exit 0 (nodejs/node#64833); runs of the 2088-test
332+
suite reported between 2046 and 2088. Every test file now exits on its own,
333+
so the flag is gone, and the watchdog still bounds a leaked handle.
329334
- The AppShots bare modifier monitor waits for `xinput --version` before it
330335
starts its XInput 2 stream, and reports `permission-denied` when the X
331336
server cannot be reached or has no XInput 2. Before, it judged the stream

‎scripts/ci/run-node-checks.sh‎

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -33,10 +33,8 @@ run_node_tests() {
3333
# off, so every step that can fail returns its status itself.
3434
node scripts/ci/manage-labels.js --check || return
3535

36-
if node --help | grep -q -- "--test-force-exit"; then
37-
# All assertions must finish, but a leaked worker handle must not hold CI open.
38-
node_test_args+=(--test-force-exit)
39-
fi
36+
# No --test-force-exit: it can drop finished tests from the report and still
37+
# exit 0 (nodejs/node#64833). The watchdog below bounds a leaked handle.
4038

4139
# Every *.test.js and every test.js; a git pathspec * also matches /.
4240
while IFS= read -r file; do

0 commit comments

Comments
 (0)