Skip to content

avoid unnecessary pr update calls#738

Merged
aviator-app[bot] merged 2 commits intomasterfrom
skip-noop-pr-updates
May 5, 2026
Merged

avoid unnecessary pr update calls#738
aviator-app[bot] merged 2 commits intomasterfrom
skip-noop-pr-updates

Conversation

@tulioz
Copy link
Copy Markdown
Contributor

@tulioz tulioz commented May 4, 2026

resending unchanged fields like BaseRefName makes github fire extra pull_request webhooks, doubling workflow runs in consumer repos.

@tulioz tulioz requested a review from a team as a code owner May 4, 2026 23:34
@aviator-app
Copy link
Copy Markdown
Contributor

aviator-app Bot commented May 4, 2026 •
edited
Loading

Current Aviator status

Aviator will automatically update this comment as the status of the PR changes.
Comment /aviator refresh to force Aviator to re-examine your PR (or learn about other /aviator commands).

This PR was merged using Aviator.

See the real-time status of this PR on the Aviator webapp.
Use the Aviator Chrome Extension to see the status of your PR within GitHub.

@aviator-app
Copy link
Copy Markdown
Contributor

aviator-app Bot commented May 4, 2026 •
edited
Loading

✅ FlexReview Status

Common Owner: aviator-co/engineering (expert-load-balance assignment)
Owner and Assignment:

  • ✅ aviator-co/engineering (expert-load-balance assignment)
    Owned Files
    • 🔒 .gitignore
    • 🔒 cmd/av/auth.go
    • 🔒 cmd/av/branch.go
    • 🔒 cmd/av/commit.go
    • 🔒 cmd/av/diff.go
    • 🔒 cmd/av/helpers.go
    • 🔒 cmd/av/pr.go
    • 🔒 cmd/av/reorder.go
    • 🔒 cmd/av/stack_foreach.go
    • 🔒 cmd/av/switch.go
    • 🔒 cmd/av/sync.go
    • 🔒 internal/actions/pr.go
    • 🔒 internal/actions/reviewers.go
    • 🔒 internal/gh/pullrequest.go
    • 🔒 internal/git/git.go
    • 🔒 internal/reorder/deletebranch.go
    • 🔒 docs/internal/md2man/md2man.go
    • 🔒 internal/gh/ghui/push.go
    • 🔒 internal/git/gittest/repo.go

Review SLO: 7 business hours if PR size is <= 200 LOC for the first response.
❕ This PR modifies 210 lines, which is larger than the Review SLO threshold.

@aviator-app aviator-app Bot requested a review from davi-maciel May 4, 2026 23:34
gemini-code-assist[bot]
gemini-code-assist Bot reviewed May 4, 2026
View reviewed changes
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new UpdatePullRequestIfChanged method to the GitHub client to avoid redundant API calls and webhooks by verifying if fields have actually changed before performing an update. It also includes widespread formatting adjustments to fmt.Fprint calls and updates the .gitignore. Feedback suggests improving the change detection logic by normalizing branch name prefixes and line endings in the pull request body to prevent false-positive updates.

Comment thread internal/gh/pullrequest.go
@tulioz tulioz force-pushed the skip-noop-pr-updates branch from 3c531b4 to 3ab8ad8 Compare May 5, 2026 01:03
@aviator-app aviator-app Bot merged commit 13b8bf5 into master May 5, 2026
6 of 8 checks passed
@aviator-app aviator-app Bot deleted the skip-noop-pr-updates branch May 5, 2026 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@simsinght simsinght simsinght approved these changes

@davi-maciel davi-maciel Awaiting requested review from davi-maciel

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tulioz @simsinght