fix goreleaser ignore_tags pattern to use glob syntax#725
Merged
aviator-app[bot] merged 1 commit intomasterfrom Apr 22, 2026
Merged
fix goreleaser ignore_tags pattern to use glob syntax#725aviator-app[bot] merged 1 commit intomasterfrom
aviator-app[bot] merged 1 commit intomasterfrom
Conversation
Contributor
Current Aviator status
This PR was merged using Aviator.
See the real-time status of this PR on the
Aviator webapp.
Use the Aviator Chrome Extension
to see the status of your PR within GitHub.
|
Contributor
✅ FlexReview StatusCommon Owner:
Review SLO: |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
| git: | ||
| ignore_tags: | ||
| - ".*-nightly" | ||
| - "*-nightly" |
There was a problem hiding this comment.
The change to glob syntax is correct. However, consider using *-nightly* (adding a trailing asterisk) to ensure that nightly tags with suffixes (e.g., v1.0.0-nightly.20231027 or build numbers) are also correctly ignored. The current pattern *-nightly only matches tags that end exactly with that string.
- "*-nightly*"
simsinght
approved these changes
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
goreleaser passes ignore_tags to git describe --exclude which expects glob, not regex